Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make SXElement completely internal #1322

Closed
ghorn opened this issue Jan 23, 2015 · 4 comments
Closed

make SXElement completely internal #1322

ghorn opened this issue Jan 23, 2015 · 4 comments
Assignees
@ghorn
Labels
enhancement
Milestone
Version 2.3.0

Comments

@ghorn
Copy link
Member

ghorn commented Jan 23, 2015

There are some API functions which have SXElement as an argument or return value. This is probably an accident, since the SXElement class is supposed to be internal
@ghorn ghorn added this to the Version 2.3.0 milestone Jan 23, 2015
@ghorn ghorn self-assigned this Jan 23, 2015
@jaeandersson
Copy link
Member

Please be more specific. Which functions? There might be some leftovers from #983.

@ghorn
Copy link
Member Author

ghorn commented Jan 27, 2015

You can try for yourself with

$ grep -n10 "std::vector<(casadi::SXElement)>" ~/casadi-2.2.0/build/swig/json/casadi.json

https://gist.github.com/ghorn/1d3be472ec61f666e130

If you just grep for SXElement you have to filter out Matrix<SXElement>

@jaeandersson
Copy link
Member

OK, you're right. Should be a bit less after #1320, but there are probably some more leftovers.

jaeandersson added a commit that referenced this issue Jan 29, 2015
@jaeandersson
#1322 Renamed norm_inf_mul_nn --> norm_inf_mul, changed signature
dbde6a9 
The function now returns a 1-by-1 matrix and the work vectors are not exposed to SWIG. If one wants
to pass work vectors, one has to work with the C runtime directly.
jaeandersson added a commit that referenced this issue Jan 29, 2015
@jaeandersson
#1322 Refactored norm_0_mul, moved implementation to Sparsity class
aab5099
jaeandersson added a commit that referenced this issue Mar 15, 2015
@jaeandersson
#1322 Refactored Matrix constructors
0578c13
jaeandersson added a commit that referenced this issue Mar 15, 2015
@jaeandersson
#1322 Removed the Matrix(vector, int, int) constructor
c55e43d 
Use syntax reshape(Matrix(vector), int, int) instead
jaeandersson added a commit that referenced this issue Mar 15, 2015
@jaeandersson
#1322 Matrix::__float__ now %rename of getValue()
bf256ef 
Use float(A) and int(A) instead of A.getValue(), A.getIntValue()
jaeandersson added a commit that referenced this issue Mar 15, 2015
@jaeandersson
#1322 Updated Matrix::quad_form
6ef8897 
Now only defined for vectors
jaeandersson added a commit that referenced this issue Mar 15, 2015
@jaeandersson
#1322 Removed (old) Matrix::nonzeros(), MX::nonzeros()
a1ab77b
jaeandersson added a commit that referenced this issue Mar 15, 2015
@jaeandersson
#1322 Added new Matrix::nonzeros()
7eadffb 
Returns nonzeros
jaeandersson added a commit that referenced this issue Mar 15, 2015
@jaeandersson
#1322 Removed dead code
d750cdf
jaeandersson added a commit that referenced this issue Mar 15, 2015
@jaeandersson
#1322 Removed unused arguments to Matrix::set, get
c76957e
jaeandersson added a commit that referenced this issue Mar 15, 2015
@jaeandersson
#1322 Removed unused arguments to Matrix::set, get (2)
2f90ad0
jaeandersson added a commit that referenced this issue Mar 15, 2015
@jaeandersson
#1322 Unexposed Matrix::data() from SWIG
ed55253
jaeandersson added a commit that referenced this issue Mar 15, 2015
@jaeandersson
#1322 Removed Matrix::addMultiple
782c156
jaeandersson added a commit that referenced this issue Mar 15, 2015
@jaeandersson
#1322 Updated type of Matrix::triplet
ad7a13c
jaeandersson added a commit that referenced this issue Mar 15, 2015
@jaeandersson
#1322 Fixed broken unit test
ba7297d
jaeandersson added a commit that referenced this issue Mar 16, 2015
@jaeandersson
#1322 Fixed broken examples
fc6753f
jaeandersson added a commit that referenced this issue Mar 16, 2015
@jaeandersson
#1322 Fixed broken tutorial example
c765ff1
@jaeandersson jaeandersson mentioned this issue Mar 16, 2015
Closed
@jaeandersson
Copy link
Member

Blocked by #1360.

jaeandersson added a commit that referenced this issue Mar 17, 2015
@jaeandersson
#1322 Matrix::sparsity() return-by-value in SWIG
1fd3cca
jaeandersson added a commit that referenced this issue Mar 17, 2015
@jaeandersson
#1322 Unexposed Matrix::getBand
60575f8
@jaeandersson jaeandersson mentioned this issue Mar 17, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ghorn ghorn

Labels
enhancement
Projects
None yet
Milestone
Version 2.3.0
Development

No branches or pull requests
2 participants
@ghorn @jaeandersson