Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Benchmarks for Model and RoleManager #120

Merged
merged 2 commits into from
Jul 18, 2021

Conversation

EmperorYP7
Copy link
Member

@EmperorYP7 EmperorYP7 commented Jul 5, 2021

Signed-off-by: Yash Pandey (YP) yash.btech.cs19@iiitranchi.ac.in

Description

Added Benchmarks for casbin::Model and casbin::RoleManager.

@EmperorYP7 EmperorYP7 marked this pull request as ready for review July 16, 2021 08:33
@EmperorYP7
Copy link
Member Author

@hsluoyz @xcaptain Kindly have a look

Signed-off-by: Yash Pandey (YP) <yash.btech.cs19@iiitranchi.ac.in>
@hsluoyz
Copy link
Member

hsluoyz commented Jul 17, 2021

@xcaptain

Signed-off-by: Yash Pandey (YP) <yash.btech.cs19@iiitranchi.ac.in>
@hsluoyz hsluoyz merged commit 42dd53e into casbin:master Jul 18, 2021
@github-actions
Copy link

🎉 This PR is included in version 1.27.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@sagilio
Copy link
Member

sagilio commented Jul 18, 2021

@EmperorYP7 LGTM! but I find the difference between the two versions is close to at least 10x, do you know what might be the reason?

  1. c++
    image
  2. golang
    image

@EmperorYP7 EmperorYP7 deleted the benchmark-model branch July 18, 2021 11:54
@EmperorYP7
Copy link
Member Author

@EmperorYP7 LGTM! but I find the difference between the two versions is close to at least 10x, do you know what might be the reason?

@sagilio I did notice the difference right when I pushed it. As of yet, no. I am investigating it, making sure only the Enforce() call is benchmarked, not the AddPolicy() and other methods. I'll keep everyone updated on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants