feat: avoid duplicate code in default_role_manager #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smrpn @hackerchai @PsiACE @GopherJ please review |
Codecov Report
@@ Coverage Diff @@
## master #295 +/- ##
==========================================
- Coverage 81.51% 81.46% -0.06%
==========================================
Files 23 23
Lines 3479 3463 -16
==========================================
- Hits 2836 2821 -15
+ Misses 643 642 -1
Continue to review full report at Codecov.
|
PsiACE
reviewed
Jun 17, 2022
greenhandatsjtu
force-pushed
the
remove-duplicate
branch
from
37edb30
to
ab835e0
Compare
Done, thanks. |
PsiACE
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many duplicate code in
default_role_manager.rs, making it hard to understand and maintain code, I improved it by removing duplicate code.