Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add policyArrayToString and policyStringToArray to util #141

Merged
merged 1 commit into from
Aug 7, 2021
Merged

feat: add policyArrayToString and policyStringToArray to util #141

merged 1 commit into from
Aug 7, 2021

Conversation

nodece
Copy link
Member

@nodece nodece commented Aug 2, 2021

Signed-off-by: Zixuan Liu nodeces@gmail.com

@nodece
feat: add policyArrayToString and policyStringToArray to util
735038d 
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@nodece nodece requested a review from Zxilly August 2, 2021 15:15
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1090748294

  • 8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 76.624%
Totals Coverage Status
Change from base Build 1087506964: 0.05%
Covered Lines: 1184
Relevant Lines: 1459
💛 - Coveralls

@Zxilly
Copy link
Contributor

Zxilly commented Aug 2, 2021

plz add error catch for csv-parse import.
I want to make this as an optional dependency. And it will be helpful for minimize the size.

@nodece
Copy link
Member Author

nodece commented Aug 3, 2021

@Zxilly csv-parse should be a necessary dependency, not an optional dependency.

@Zxilly Zxilly merged commit e71b40f into casbin:v1 Aug 7, 2021
@nodece nodece deleted the v1 branch August 7, 2021 14:51
@github-actions
Copy link

🎉 This PR is included in version 1.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zxilly Zxilly Awaiting requested review from Zxilly

Assignees
No one assigned
Labels
released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nodece @coveralls @Zxilly