Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Auto-login causing AuthCodeWithPKCE Failures #2910

Closed
filwaline opened this issue Apr 29, 2024 · 1 comment · Fixed by #2911
Closed

[Bug] Auto-login causing AuthCodeWithPKCE Failures #2910

filwaline opened this issue Apr 29, 2024 · 1 comment · Fixed by #2911
Assignees
@hsluoyz
Labels
bug Something isn't working

Comments

@filwaline
Copy link
Contributor

filwaline commented Apr 29, 2024 •
edited
Loading

When auto-login is enabled, I encounter numerous failed PKCE authorizations; however, PECK works fine when auto-login disabled.

Why is codeChallenge being ignored here static_filter.go#L62? Won't this lead to failed PKCE authorization?
@casbin-bot
Copy link
Contributor

@tangyang9464 @JalinWang @imp2002

@casbin-bot casbin-bot added the bug Something isn't working label Apr 29, 2024
filwaline added a commit to filwaline/casdoor that referenced this issue Apr 29, 2024
@filwaline
fix: Auto-login causing AuthCodeWithPKCE Failures casdoor#2910
17774c5
@filwaline filwaline mentioned this issue Apr 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsluoyz hsluoyz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: fix Auto-login causing AuthCodeWithPKCE Failures filwaline/casdoor
3 participants
@hsluoyz @filwaline @casbin-bot