Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reimplement default role manager #285

Merged
merged 2 commits into from
Aug 11, 2022

Conversation

seriouszyx
Copy link
Member

Fix: #261

Signed-off-by: Yixiang Zhao seriouszyx@foxmail.com

Signed-off-by: Yixiang Zhao <seriouszyx@foxmail.com>
@casbin-bot
Copy link
Member

@tangyang9464 @imp2002 please review

@hsluoyz
Copy link
Member

hsluoyz commented Jul 22, 2022

@tangyang9464

Signed-off-by: Yixiang Zhao <seriouszyx@foxmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #285 (04706d3) into master (51d1294) will increase coverage by 1.31%.
The diff coverage is 93.24%.

@@            Coverage Diff             @@
##           master     #285      +/-   ##
==========================================
+ Coverage   66.75%   68.07%   +1.31%     
==========================================
  Files          45       47       +2     
  Lines        2262     2371     +109     
  Branches      394      405      +11     
==========================================
+ Hits         1510     1614     +104     
- Misses        633      643      +10     
+ Partials      119      114       -5     
Impacted Files Coverage Δ
...n/java/org/casbin/jcasbin/util/SyncedLRUCache.java 90.00% <90.00%> (ø)
...in/java/org/casbin/jcasbin/rbac/DomainManager.java 91.35% <91.35%> (ø)
...va/org/casbin/jcasbin/rbac/DefaultRoleManager.java 92.23% <93.67%> (+8.71%) ⬆️
src/main/java/org/casbin/jcasbin/rbac/Role.java 94.64% <95.45%> (+4.89%) ⬆️
...ain/java/org/casbin/jcasbin/main/CoreEnforcer.java 79.19% <100.00%> (ø)
...java/org/casbin/jcasbin/util/BuiltInFunctions.java 86.48% <100.00%> (+0.67%) ⬆️
...rc/main/java/org/casbin/jcasbin/util/LRUCache.java 100.00% <100.00%> (ø)
...jcasbin/exception/CasbinNameNotExistException.java 0.00% <0.00%> (-100.00%) ⬇️
src/main/java/org/casbin/jcasbin/util/Util.java 58.24% <0.00%> (-3.30%) ⬇️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@hsluoyz
Copy link
Member

hsluoyz commented Jul 28, 2022

@tangyang9464

Copy link
Member

@tangyang9464 tangyang9464 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hsluoyz hsluoyz merged commit aaa4f18 into casbin:master Aug 11, 2022
@github-actions
Copy link

🎉 This PR is included in version 1.26.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Reimplement default role manager
5 participants