-
-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: reimplement default role manager #285
Conversation
Signed-off-by: Yixiang Zhao <seriouszyx@foxmail.com>
@tangyang9464 @imp2002 please review |
Signed-off-by: Yixiang Zhao <seriouszyx@foxmail.com>
Codecov Report
@@ Coverage Diff @@
## master #285 +/- ##
==========================================
+ Coverage 66.75% 68.07% +1.31%
==========================================
Files 45 47 +2
Lines 2262 2371 +109
Branches 394 405 +11
==========================================
+ Hits 1510 1614 +104
- Misses 633 643 +10
+ Partials 119 114 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
🎉 This PR is included in version 1.26.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Fix: #261
Signed-off-by: Yixiang Zhao seriouszyx@foxmail.com