Wrap getContainerRenderWindow loop in try/catch #801
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lixun910
reviewed
Oct 18, 2021
Comment on lines
+23
to
+27
| try { | ||
| while (!renderWindow.document.contains(container) && renderWindow.parent !== renderWindow) { | ||
| renderWindow = renderWindow.parent | ||
| } | ||
| } catch (error) {} |
There was a problem hiding this comment.
@casesandberg @itsjoekent For cross-domain error, the renderWindow.document will raise DOMException. At this point, is the renderWindow already an invalid object, which can not be returned?
This works on my test:
let renderWindow = window
let lastRenderWindow = window
try {
while (!renderWindow.document.contains(container) && renderWindow.parent !== renderWindow) {
lastRenderWindow = renderWindow
renderWindow = renderWindow.parent
}
} catch(error) {
// handle possible cross-origin error, if happens then use current window in frame
}
return lastRenderWindow
There was a problem hiding this comment.
For cross-domain error , it's cannot access renderWindow.document when renderWindow is parent iframe
There was a problem hiding this comment.
use it in inner iframe, when cross-domain, 'renderWindow.document' will throw error, please reconfirm and repair
|
When can this pr be merged? The problem mentioned in the issue #806 is still causing crashes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #798
@casesandberg Can you merge + publish this? This is causing our application to fail in production