Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin 1.4.0 and AGP 4.0.1 #96

Merged
merged 2 commits into from
Aug 14, 2020
Merged

Kotlin 1.4.0 and AGP 4.0.1 #96

merged 2 commits into from
Aug 14, 2020

Conversation

saket
Copy link
Collaborator

@saket saket commented Aug 14, 2020

No description provided.

@saket
Copy link
Collaborator Author

saket commented Aug 14, 2020

prepareLintJarForPublish is failing due to a bug in AGP: https://issuetracker.google.com/issues/161727305

* What went wrong:
Execution failed for task ':contour:prepareLintJarForPublish'.
> A failure occurred while executing com.android.build.gradle.internal.tasks.Workers$ActionFacade
   > Found more than one jar in the 'lintPublish' configuration. Only one file is supported. If using a separate Gradle project, make sure compilation dependencies are using compileOnly

Adding a compileOnly dependency on kotlin-stdlib seems to fix the problem.

@saket saket merged commit 901413a into master Aug 14, 2020
@saket saket deleted the saket/aug14/kotlin-140 branch August 14, 2020 20:37
@jrodbx
Copy link
Collaborator

jrodbx commented Aug 14, 2020

Won't this break potentially consumers if directly depend on a different kotlin version than Contour? seems dangerous.

@saket
Copy link
Collaborator Author

saket commented Aug 17, 2020

I'm slightly the fence on this one, but I think I'm okay releasing this. If we don't release, contour will become a bottleneck for projects wanting to update to Kotlin 1.4. If we release, older projects might run into errors if contour-lint uses stdlib APIs that aren't present on the classpath. That isn't the case right now so I feel it's safe for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants