Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add crane container tools cli #268

Merged
merged 2 commits into from
Jan 18, 2023
Merged

add crane container tools cli #268

merged 2 commits into from
Jan 18, 2023

Conversation

DaveSys911
Copy link
Contributor

This was referenced Jan 18, 2023
Closed
Closed
alecthomas
alecthomas requested changes Jan 18, 2023
View reviewed changes
Copy link
Collaborator

@alecthomas alecthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Needs a couple of tweaks to work, but otherwise LGTM!

crane.hcl Outdated Show resolved Hide resolved
crane.hcl Outdated Show resolved Hide resolved
@DaveSys911
Copy link
Contributor Author

Thank you!

Needs a couple of tweaks to work, but otherwise LGTM!

Thanks for the quick reply. Done- could u re-review and allow CI to run please?

@alecthomas alecthomas merged commit 0f63b7c into cashapp:master Jan 18, 2023
@alecthomas
Copy link
Collaborator

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecthomas alecthomas Awaiting requested review from alecthomas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaveSys911 @alecthomas