Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(cashapp#288) Addresses error messaging on invalid version #379

Merged
merged 1 commit into from
Jun 1, 2023
Merged

(cashapp#288) Addresses error messaging on invalid version #379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manifest/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ func TestManifest(t *testing.T) {
version "1.14.4" {}
`,
pkg: "go-1.14.5",
fail: "memory:///go.hcl: no version go-1.14.5 found in versions (go-1.14.4) or channels (go@1, go@1.14, go@latest): unknown package",
fail: "memory:///go.hcl: no version go-1.14.5 found in versions (go-1.14.4) or channels (go@1, go@1.14, go@latest), try \"hermit update\": unknown package",
},
{name: "InvalidVariable",
manifest: `
Expand Down
2 changes: 1 addition & 1 deletion manifest/resolver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ func newPackage(manifest *AnnotatedManifest, config Config, selector Selector) (
return nil, errors.Wrapf(ErrUnknownPackage, "%s: no channel %s found in channels (%s) or versions (%s)",
manifest.Path, selector, strings.Join(knownChannels, ", "), strings.Join(knownVersions, ", "))
}
return nil, errors.Wrapf(ErrUnknownPackage, "%s: no version %s found in versions (%s) or channels (%s)",
return nil, errors.Wrapf(ErrUnknownPackage, "%s: no version %s found in versions (%s) or channels (%s), try \"hermit update\"",
manifest.Path, selector, strings.Join(knownVersions, ", "), strings.Join(knownChannels, ", "))
}

Expand Down