Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Increase github version lookup to 200 #411

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

damar-block
Copy link
Collaborator

In case of updating nodejs/node v17 - the last v17 tag is more than 100 tags behind the latest, causing the existing auto-version logic to fail.

We will fix this further by supporting to update auto-version of a specific version (instead of today's logic to go through all the auto-versioned packages).

@alecthomas
Copy link
Collaborator

Just note that that limit is there to avoid spamming the GH API.

@alecthomas alecthomas merged commit 9cc873a into master Jun 21, 2024
6 checks passed
@alecthomas alecthomas deleted the damar.inc_history branch June 21, 2024 00:52
@damar-block
Copy link
Collaborator Author

Just note that that limit is there to avoid spamming the GH API.

Yes, we will follow up by supporting updating a single version, which should decrease calls to GH APIs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants