Do not perform dependency verification on the poms we resolve #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
force-pushed
the
jw/no-dependency-verification/2022-03-23
branch
from
7145596
to
b35b39d
Compare
JakeWharton
force-pushed
the
jw/no-dependency-verification/2022-03-23
branch
from
b35b39d
to
2d868f2
Compare
JakeWharton
force-pushed
the
jw/no-dependency-verification/2022-03-23
branch
from
2d868f2
to
49d6a26
Compare
|
The test still doesn't work. Tried all kinds of things. I want to make a release so I'm going to land the fix with the test that doesn't actually validate the behavior for now. |
mattprecious
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't get the test to fail (yet?) with the fix commented out.
Closes #78