Load resource paths from Android Gradle Plugin #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinzheng-ap
commented
May 4, 2023
paparazzi/paparazzi-gradle-plugin/src/main/java/app/cash/paparazzi/gradle/PaparazziPlugin.kt
Show resolved
Hide resolved
kevinzheng-ap
changed the title
jrodbx
changed the title
jrodbx
requested changes
May 4, 2023
paparazzi/paparazzi-gradle-plugin/src/main/java/app/cash/paparazzi/gradle/PaparazziPlugin.kt
Outdated
Show resolved
Hide resolved
paparazzi/paparazzi-gradle-plugin/src/main/java/app/cash/paparazzi/gradle/PaparazziPlugin.kt
Outdated
Show resolved
Hide resolved
paparazzi/paparazzi-gradle-plugin/src/main/java/app/cash/paparazzi/gradle/PaparazziPlugin.kt
Outdated
Show resolved
Hide resolved
paparazzi/paparazzi-gradle-plugin/src/main/java/app/cash/paparazzi/gradle/PaparazziPlugin.kt
Outdated
Show resolved
Hide resolved
...azzi/paparazzi-gradle-plugin/src/main/java/app/cash/paparazzi/gradle/PrepareResourcesTask.kt
Outdated
Show resolved
Hide resolved
...razzi/paparazzi-gradle-plugin/src/test/java/app/cash/paparazzi/gradle/PaparazziPluginTest.kt
Outdated
Show resolved
Hide resolved
...razzi/paparazzi-gradle-plugin/src/test/java/app/cash/paparazzi/gradle/PaparazziPluginTest.kt
Outdated
Show resolved
Hide resolved
...zzi-gradle-plugin/src/test/projects/verify-resources-kotlin/src/main/res/drawable/camera.png
Outdated
Show resolved
Hide resolved
...razzi-gradle-plugin/src/test/projects/verify-resources-java/src/main/res/drawable/camera.png
Outdated
Show resolved
Hide resolved
paparazzi/paparazzi-gradle-plugin/src/main/java/app/cash/paparazzi/gradle/PaparazziPlugin.kt
Show resolved
Hide resolved
kevinzheng-ap
force-pushed
the
load-resources-paths-from-gradle
branch
from
e911126
to
1d047ff
Compare
jrodbx
approved these changes
May 5, 2023
paparazzi/paparazzi-gradle-plugin/src/test/projects/verify-resources-java/src/libs/external.aar
Outdated
Show resolved
Hide resolved
paparazzi/paparazzi-gradle-plugin/src/test/projects/verify-resources-kotlin/build.gradle
Outdated
Show resolved
Hide resolved
kevinzheng-ap
commented
May 5, 2023
...razzi/paparazzi-gradle-plugin/src/test/java/app/cash/paparazzi/gradle/PaparazziPluginTest.kt
Show resolved
Hide resolved
kevinzheng-ap
force-pushed
the
load-resources-paths-from-gradle
branch
from
ef4858a
to
69ac5b2
Compare
kevinzheng-ap
force-pushed
the
load-resources-paths-from-gradle
branch
from
69ac5b2
to
862a2f3
Compare
jrodbx
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load resources paths from Android Gradle Plugin for new resource loading mechanism. Also updated associated tests
Part of #524
cc @jrodbx @fredliao123