Fix crash on scroll position restoration #1606
Conversation
| @@ -107,7 +107,7 @@ internal open class ViewLazyList private constructor( | |||
| val viewsOnScreen = recyclerView.children.map { recyclerView.getChildViewHolder(it).bindingAdapterPosition } | |||
| userHasScrolled = true // Prevent guest code from hijacking the scrollbar. | |||
| onViewportChanged?.invoke( | |||
| viewsOnScreen.min(), | |||
| viewsOnScreen.min().coerceAtLeast(0), | |||
There was a problem hiding this comment.
.min() sometimes returns -1 (which had been observed / is expected)
There was a problem hiding this comment.
-1 is NO_POSITION which is what is returned for all positions between adapter invalidations and the next layout pass.
Also min and max throw if the sequence is empty, are we assuming the scroll callback will never be invoked on an empty list?
There was a problem hiding this comment.
Also min and max throw if the sequence is empty, are we assuming the scroll callback will never be invoked on an empty list?
ahhh 🤔, that's the case (not invoked on empty list) so far (this has only only been applied to emoji search). But it's not guaranteed the invocation wouldn't happen on an empty list (someone else might use it, or other teams might use it).
-1 is NO_POSITION which is what is returned for all positions between adapter invalidations and the next layout pass.
👍
|
I need another round of internal release when this is in. |
Fixes: #1604