Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Class or ClassLoader to be provided to ResourceCodeResolver #15

Closed
mtdowling opened this issue Sep 26, 2020 · 4 comments
Closed

Allow Class or ClassLoader to be provided to ResourceCodeResolver #15

mtdowling opened this issue Sep 26, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@mtdowling
Copy link

Applications that need to use very specific class loaders may wish to use ResourceCodeResolver but using a custom ClassLoader or even Class. I think that passing a Class would negate the need for a root too. Currently ResourceCodeResolver always uses the context class loader.
@casid
Copy link
Owner

casid commented Sep 26, 2020

@mtdowling that's a good idea! Would you like to contribute a pull request for it?

@casid casid added the enhancement New feature or request label Sep 26, 2020
casid added a commit that referenced this issue Oct 8, 2020
@casid
#15 Allow ClassLoader to be provided to ResourceCodeResolver
476e64a
@casid
Copy link
Owner

casid commented Oct 8, 2020

Hey @mtdowling, I've added another constructor to ResourceCodeResolver, that allows to pass a custom ClassLoader.

476e64a

Does this help with your use case?

@mtdowling
Copy link
Author

Cool thanks!

@casid
Copy link
Owner

casid commented Oct 14, 2020

Awesome, thanks for closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mtdowling @casid