Fix compilation with too long constant strings

[kelunik]

Length calculation is based on modified UTF-8.

References:

• https://github.com/openjdk/jdk/blob/a8a2246158bc53414394b007cbf47413e62d942e/src/java.base/share/classes/java/io/DataOutputStream.java#L351-L358
• https://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.4.7

Fixes #25.

[codecov-io]

Codecov Report

Merging #26 into master will decrease coverage by 89.53%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #26       +/-   ##
============================================
- Coverage     89.53%   0.00%   -89.54%     
============================================
  Files            47      47               
  Lines          1978    1996       +18     
  Branches        329     336        +7     
============================================
- Hits           1771       0     -1771     
- Misses          123    1996     +1873     
+ Partials         84       0       -84     

Impacted Files	Coverage Δ	Complexity Δ
...rc/main/java/gg/jte/internal/TemplateCompiler.java	0.00% <0.00%> (-94.71%)	0.00 <0.00> (-31.00)
jte-runtime/src/main/java/gg/jte/Content.java	0.00% <0.00%> (-100.00%)	0.00% <0.00%> (-1.00%)
jte-runtime/src/main/java/gg/jte/ContentType.java	0.00% <0.00%> (-100.00%)	0.00% <0.00%> (-1.00%)
jte-runtime/src/main/java/gg/jte/CodeResolver.java	0.00% <0.00%> (-100.00%)	0.00% <0.00%> (-1.00%)
...runtime/src/main/java/gg/jte/html/HtmlContent.java	0.00% <0.00%> (-100.00%)	0.00% <0.00%> (-1.00%)
...untime/src/main/java/gg/jte/TemplateException.java	0.00% <0.00%> (-100.00%)	0.00% <0.00%> (-2.00%)
...ntime/src/main/java/gg/jte/internal/ClassInfo.java	0.00% <0.00%> (-100.00%)	0.00% <0.00%> (-4.00%)
...ntime/src/main/java/gg/jte/internal/DebugInfo.java	0.00% <0.00%> (-100.00%)	0.00% <0.00%> (-1.00%)
...ime/src/main/java/gg/jte/html/OwaspHtmlPolicy.java	0.00% <0.00%> (-100.00%)	0.00% <0.00%> (-1.00%)
...me/src/main/java/gg/jte/internal/TemplateMode.java	0.00% <0.00%> (-100.00%)	0.00% <0.00%> (-1.00%)
... and 38 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f7c80a...50bf527. Read the comment docs.

[kelunik]

Interesting, Windows seems to have different constant pool sizes. I'll have a look.

D:\a\jte\jte\jte\jte-classes\gg\jte\generated\test\JtetemplateGenerated.java:2: error: UTF8 representation for string "?????..." is too long for the constant pool

[casid]

Nice, thanks for PR @kelunik! I'll try to hop over to my windows PC and have a look at the failing tests.

[casid]

Running the tests on Windows via IntelliJ results in no errors. Will try maven...

[casid]

@kelunik okay when I run the tests via maven on Windows all multibyte offset tests fail here as well. Maybe some difference in JVM startup parameters compared to maven?

[casid]

It seems that unicode output on Windows via maven doesn't give the desired output at all. Rendering a single Mr Poo works fine via IntelliJ launcher but fails when executed by maven surefire plugin. I committed the test to see if it is the case on Github Action, too.

[ERROR]   TemplateEngineTest.templateWithoutParameters_mrPoo:42->thenOutputIs:1136 
Expecting:
 <"💩">
to be equal to:
 <"💩">
but was not.

[kelunik]

Interesting, the GitHub Action says:

Expecting:
 <"💩">
to be equal to:
 <"?">

[casid]

Applying this argline to the surefire plugin worked for me locally, let's see what the Github Action is doing.

[kelunik]

I just committed the same change. 😄

[kelunik]

@casid What's the default encoding on your Windows JVM? java -XshowSettings should show it.

[casid]

@kelunik this seems to be file.encoding = Cp1252.

[kelunik]

I can reproduce it locally with <argLine>-Dfile.encoding=ISO-8859-1</argLine> :-)

[casid]

Nice! I've added one more test, just for the sake of coverage and would merge the PR after the build ran through. Thanks for fixing this @kelunik :-)