Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Minor adjustments for dependabot pull requests #345

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

marcospereira
Copy link
Contributor

What?

Two minor changes based on the first PR (#344) opened by dependabot.

  • Since it creates a branch in the repository instead of a fork, it runs the workflows twice (one for the PR and one for the push). Therefore, pushes will only run now when it is for the main branch.
  • It should not try to upload code coverage.

@@ -9,9 +9,8 @@ on:
- 'docs/**'
- 'mkdocs.yml'
push:
paths-ignore:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is the main branch, we always want to run all workflows.

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.31%. Comparing base (376f241) to head (e0d6ac5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #345   +/-   ##
=========================================
  Coverage     91.31%   91.31%           
  Complexity     1218     1218           
=========================================
  Files            76       76           
  Lines          3168     3168           
  Branches        493      493           
=========================================
  Hits           2893     2893           
  Misses          164      164           
  Partials        111      111           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcospereira
Copy link
Contributor Author

Updating codecov/codecov-action to version v4 broke Codecov uploading because now a token is required:

https://github.com/codecov/codecov-action/blob/v4/README.md#breaking-changes

Example of broken workflow run:

https://github.com/casid/jte/actions/runs/8571119047

Tokenless uploading is unsupported. However, PRs made from forks to the upstream public repos will support tokenless (e.g. contributors to OS projects do not need the upstream repo's Codecov token)

The Codecov docs related token setup are here: https://docs.codecov.com/docs/adding-the-codecov-token.

@casid, it seems I can remove e545b7f, but you will need to create the Codecov token.

@casid
Copy link
Owner

casid commented Apr 9, 2024

Hi @marcospereira!

Thanks for the hint with the token, I've added it as a secret.

I'm merging this PR now.

@casid casid merged commit 943b854 into casid:main Apr 9, 2024
9 checks passed
@marcospereira marcospereira deleted the ci/minor-adjustments branch April 9, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants