Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle priority in epl-package-version #33

Closed
wants to merge 1 commit into from
Closed

Conversation

Silex
Copy link
Contributor

@Silex Silex commented Nov 7, 2016

Fix #32

@fommil: can you test that this fixes it?

@fommil
Copy link

fommil commented Nov 8, 2016

nope, this deleted a bunch of packages then seemed to try to reinstall some things without their deps available.

@Silex
Copy link
Contributor Author

Silex commented Nov 8, 2016

Very weird, it's one of these case where I can't see why it would not work.

I mean, it's what package.el uses:

(defun package-archive-priority (archive)
  "Return the priority of ARCHIVE.

The archive priorities are specified in
`package-archive-priorities'. If not given there, the priority
defaults to 0."
  (or (cdr (assoc archive package-archive-priorities))
      0))

(defun package-desc-priority-version (pkg-desc)
  "Return the version PKG-DESC with the archive priority prepended.

This allows for easy comparison of package versions from
different archives if archive priorities are meant to be taken in
consideration."
  (cons (package-desc-priority pkg-desc)
        (package-desc-version pkg-desc)))

I guess the fact that package.el also deletes the old package has to be taken in account... That or you tested wrongly 😜

I'll try to test by actually using package-archive-priorities when I have time.

@Silex
Copy link
Contributor Author

Silex commented Nov 14, 2016

@lunaryorn: I realised that implementing around package.el was actually pretty simple, so I did it. I don't depend on epl anymore.

This PR should be close to the right thing to do, but apparently it isn't, and I don't feel like debugging it further.

Feel free to close or keep it open as a future TODO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support package-archive-priorities
3 participants