Restore gossip peer selection #4615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdHastingsCasperAssociation
approved these changes
Apr 9, 2024
marc-casperlabs
merged commit 21eb439
into
casper-network:feat-1.6
1 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restore the gossiping peer selection. Note that the original method of sampling the outgoing limiter was not portable, since we do not keep a pre-built mapping of which
NodeIds are validators ready. The use of the validator matrix changes, requiring only one lock instead ofO(# connected peers).Furthermore, the setting is now configurable, should it cause issues.