Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support --incl & --excl when --loc=ins,del #89

Open
tredeske opened this issue Mar 24, 2023 · 3 comments
Open

support --incl & --excl when --loc=ins,del #89

tredeske opened this issue Mar 24, 2023 · 3 comments
Assignees

Comments

@tredeske
Copy link

tredeske commented Mar 24, 2023

Using the containerized version (podman on linux), --excl appears to have no effect on loc or other stats.

$ podman run --rm -it --userns=keep-id -v /path/to/myrepo:/repo:Z casperdcl/git-fame -s --since 91.days --cost cocomo -M -C --excl='.*' --loc 'ins,del'

$ podman run --rm -it --userns=keep-id -v /path/to/myrepo:/repo:Z casperdcl/git-fame -v
2.0.1

$ git --version
git version 2.31.1

Exclusions tried:

  • --excl='dir' - to exclude a dir
  • --excl='.*/dir/.*' - to exclude a dir
  • --excl='.*dir/.*' - to exclude a dir
  • --excl='.*file.*' - to exclude a file
  • --excl='.*' - exclude everything

Using -n with explicitly listed files also fails to exclude.

Using --log=DEBUG verifies that the regex was received by git-fame as expected.

Using --incl='regex' also appears to have no effect. Examples:

  • --incl='.*file' - should just include the one file, but includes all files
  • --incl='non-existent-file' - still includes everything
@ntcong
Copy link

ntcong commented Jul 13, 2023

if you use any loc other than surv, the excl parameter got ignored

@twam
Copy link

twam commented Oct 2, 2023

Maybe something worth mentioning on --help. :)

@tredeske
Copy link
Author

An update to the cmdline help would be useful, as would emitting an error if loc conflicts with excl. Better would be enabling excl to have an effect regardless of loc.

@casperdcl casperdcl added the bug label Oct 6, 2024
@casperdcl casperdcl changed the title excl appears to have no effect support --incl & --excl when --loc=ins,del Oct 6, 2024
@casperdcl casperdcl self-assigned this Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants