Child container disposals #335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased with master |
jonorossi
requested changes
Sep 19, 2017
| if (parentHandler.ComponentModel.LifestyleType == LifestyleType.Singleton || parentHandler.ComponentModel.LifestyleType == LifestyleType.Undefined) | ||
| releasePolicy = Parent.ReleasePolicy; | ||
| else | ||
| releasePolicy = this.ReleasePolicy; |
There was a problem hiding this comment.
This will break many scenarios, if the component was registered and resolved by the parent container it might not be a transient, what about pooled, scoped or any custom lifestyle. The component should follow and be tracked by the release policy of the container it was registered in, however understand this isn't really the desired behaviour for transients.
Unfortunately the fix for this won't be so easy, as you can see child containers haven't really been designed.
Windsor however has followed the rule that if you call Resolve you must also call Release even for transients, which would fix the unit test.
ghost
mentioned this pull request
|
Closing as per #338 |
ghost
closed this
ghost
deleted the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for #324