Obsolete methods that can be removed safely #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
ghost
requested a review
from
ghost
mentioned this pull request
7 tasks
jonorossi
reviewed
Feb 10, 2018
| @@ -65,26 +65,6 @@ container.Register( | |||
| ); | |||
| ``` | |||
|
|
|||
| ### What does ActAs do? | |||
There was a problem hiding this comment.
Did you forget to remove ActAs from ComponentRegistration?
There was a problem hiding this comment.
Must have accidentally omitted that commit when I squished everything.
|
Looks good, just a comment about |
added 3 commits
February 11, 2018 19:19
This PR mainly targets: - ActAs - Parameters - ServiceOverrides - Properties - Most methods in DefaultKernel_ObsoleteAPI - Most methods in WindsorContainer_ObsoleteAPI Obsolete methods that can be removed safely: - Removed obsolete Resolve methods from IKernel/DefaultKernel && IWindsorContainer/WindsorContainer - Removed the obsolete AddComponent methods from IKernel/DefaultKernel - Removed the obsolete indexer from IKernel/DefaultKernel && IWindsorContainer/WindsorContainer - Removed the obsolete Properties methods from Component Registration - Removed the obsolete ServiceOverrides methods from Component Registration - Removed the obsolete Parameter method from Component Registration - Removed the obsolete ActAs method from Component Registrations and updated documentation Obsolete methods that cannot be removed safely: - IKernel/DefaultKernel AddFacility(String key, IFacility facility) - IWindsorContainer/WindsorContainer AddFacility(String key, IFacility facility) Still need to update CHANGELOG.md but will wait to avoid merge conflict.
|
All good. |
|
Thanks. I will come back on the other PR tomorrow night. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses obsolescence from issue #338
This PR mainly targets:
Obsolete methods that can be removed safely:
Obsolete methods that cannot be removed safely:
Still need to update CHANGELOG.md but will wait to avoid merge conflict.