Collections of type Set or SortedSet generate code that does not compile #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ile. useJava50 boolean parameter was added to createGetByIndexMethod(...) in CollectionMemberAndAccessorFactory but it was not added to overridden method in CollectionJ2NoIndexMemberAndAccessorFactory
|
parent/pom.xml has a dependency on castor-maven-plugin version 3.0-SNAPSHOT which causes the build to fail. I had to change this version to 2.1 to get my local build to work but I did not commit that change. |
|
In this case having these methods annotated with @OverRide would have made these types of issues a lot more obvious but I guess it would take some considerable effort to go back and add these annotations. Might be worthwhile to add this as an enhancement or to some TODO list somewhere. |
|
Yes, that Maven plugin is work in progress right now. Privately rolling this back is the correct solution in your case, indeed. |
|
Merged pull request, and added missing @OverRide annotations to this class hierarchy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #47
useJava50 boolean parameter was added to createGetByIndexMethod(...) in CollectionMemberAndAccessorFactory but it was not added to overridden method in CollectionJ2NoIndexMemberAndAccessorFactory