fix: rename id of sai to sai_weapon
#2810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weapon `sai` was colliding with overmap terrain `sai`.
chaosvolt
approved these changes
May 11, 2023
This was referenced May 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Prevent tileset using overmap terrian for sai's sprite"
Purpose of change
i've overlooked chaosvolt's review in #2715 that the graphic glitch was due to overmap terrain and weapon sharing same id
sai.Describe the solution
renamed id of
saitosai_weapon, which changes the two uses of sai:Describe alternatives you've considered
add a migration to change
saitosai_weaponbut hopefully nobody downloaded today's experimental releases as i've deleted one with the PR #2715Testing