Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(port): Fix clang 14 build in GHA #3528

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

olanti-p
Copy link
Contributor

@olanti-p olanti-p commented Oct 30, 2023

Summary

SUMMARY: Build "[DDA Port] Fixed clang 14 build in GHA"

Purpose of change

Clang14 asan tests are failing to build.

Describe the solution

GitHub has installed gcc 13 on runners, so now clang tries to compile against gcc 13 toolchain and fails.
Solution is to trick clang into using an older gcc toolchain.
Original PR: CleverRaven/Cataclysm-DDA#62405

Describe alternatives you've considered

This could've been done with a single argument if we had clang 16 and its --gcc-install-dir option.

Testing

Waiting for GHA to complete the checks.

Additional context

tony_stark_tired_face.jpg

Checklist

If this is a C++ PR that modifies JSON loading or behavior:

  • Document the changes in the appropriate location in the doc/ folder.
  • If documentation for this feature does not exist, please write it or at least note its lack in PR description.
  • New localizable fields need to be added to the lang/bn_extract_json_strings.sh script if it does not support them yet.
  • If applicable, add checks on game load that would validate the loaded data.
  • If it modifies format of save files, please add migration from the old format.

If this is a PR that modifies build process or code organization:

  • Please document the changes in the appropriate location in the doc/ folder.
  • If documentation for this feature or process does not exist, please write it.
  • If the change alters versions of software required to build or work with the game, please document it.

If this is a PR that removes JSON entities:

  • The removed JSON entities have new entries in data/json/obsoletion/ folder.

Copy link
Collaborator

@Firestorm01X2 Firestorm01X2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try that

@scarf005 scarf005 changed the title [DDA Port] Fix clang 14 build in GHA ci(port): Fix clang 14 build in GHA Nov 1, 2023
@olanti-p olanti-p added this pull request to the merge queue Nov 1, 2023
Merged via the queue into cataclysmbnteam:upload with commit 93f7b5d Nov 1, 2023
13 checks passed
@olanti-p olanti-p deleted the fix-clang14-ci branch November 2, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants