Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Format both flavors of RetroDays #4486

Merged

Conversation

RobbieNeko
Copy link
Contributor

@RobbieNeko RobbieNeko commented Apr 14, 2024

Purpose of change

I noticed, while looking through the tileset config files for a completely unrelated reason, that the original RetroDays tileset config file was HORRIBLY formatted for some reason. For the sake of improving the keeping of style within the code at least a little bit, I have let the auto-formatter have its way with it to change it from its one-line eldritch horror nature to a respectably formatted JSON file.

Also while I was at it ran the autoformatter on the other tileset config files, and RetroDays+ had some minor formatting errors that I also found.

Describe the solution

Formats the tileset config JSON file of RetroDays and RetroDays+ to our standards

Describe alternatives you've considered

  • Leave it be

Reducing the amount of spaghetti 'code' is always good, and it's not like this could possibly harm anything

Testing

Confirmed that the game can indeed still read RetroDays even when it's properly formatted.

Additional context

The two people who use RetroDays, rejoice!

The line count on the original Retrodays reformatting will be immense, I can already predict it
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting goes nyooooom

@chaosvolt chaosvolt merged commit 6c2aa50 into cataclysmbnteam:main Apr 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants