Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content): use glue as nail alternative #4698

Merged
merged 8 commits into from
May 27, 2024

Conversation

Lamandus
Copy link
Contributor

Purpose of change

Nails can be hard to come by innawoods. This let the player use glue as an alternative. While "not as effective" as nails would be, innawoods can now rely on making glue to get boats without the need of metallurgy. Sure, nails are still superior, but that would be a nail free alternative.

Describe the solution

Using a new requirement list "nail_glue" to replace nails as an solo items where it makes sense.

Describe alternatives you've considered

Nailing...

Testing

grafik

Additional context

Checklist

@github-actions github-actions bot added the JSON related to game datas in JSON format. label May 26, 2024
@Lamandus Lamandus changed the title content: use glue as nail alternative feat(content): use glue as nail alternative May 26, 2024
Copy link
Contributor

autofix-ci bot commented May 26, 2024

Autofix has formatted code style violation in this PR.

I edit commits locally (e.g: git, github desktop) and want to keep autofix
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

@chaosvolt
Copy link
Member

I'm still leery of it being 1:1 since that's a lot of glue. Each unit of glue takes takes 10 bones to make (or 20 if making superglue, oddly enough), 10 pine boughs, 20 dandelions, 100 lye powder, etc etc...
image
image

Unrelated, but bones being twice as inefficient when used to make superglue is fucking goofy when recipes almost always use bone glue and superglue at a 1:1 ratio.

@yay855
Copy link
Contributor

yay855 commented May 26, 2024

I'm still leery of it being 1:1 since that's a lot of glue. Each unit of glue takes takes 10 bones to make (or 20 if making superglue, oddly enough), 10 pine boughs, 20 dandelions, 100 lye powder, etc etc... image image

Unrelated, but bones being twice as inefficient when used to make superglue is fucking goofy when recipes almost always use bone glue and superglue at a 1:1 ratio.

I'd say that the glue to nail ratio should be 1:10, personally. You can make a ton of nails out of a relatively small amount of metal, but you need a lot of ingredients to make one unit of glue.

@Lamandus
Copy link
Contributor Author

I'm still leery of it being 1:1 since that's a lot of glue. Each unit of glue takes takes 10 bones to make (or 20 if making superglue, oddly enough), 10 pine boughs, 20 dandelions, 100 lye powder, etc etc... image image

Unrelated, but bones being twice as inefficient when used to make superglue is fucking goofy when recipes almost always use bone glue and superglue at a 1:1 ratio.

I can just make use of "charges" for glue. So creating glue will lead to 10 charges for example.

@chaosvolt
Copy link
Member

Seems like more work than just tweaking the ratios used by the crafting requirement but if you want.

@Lamandus
Copy link
Contributor Author

I did another approach.
I made bone glue stackable and one time will create 10 charges for super glue and for bone glue
grafik

@chaosvolt chaosvolt merged commit bff72d0 into cataclysmbnteam:main May 27, 2024
10 checks passed
@Lamandus Lamandus deleted the nailglue branch September 4, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants