Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content): ammo drops in different amounts #4784

Merged
merged 4 commits into from
Jun 12, 2024

Conversation

Lamandus
Copy link
Contributor

Purpose of change

ammo spawned always with their maximum charge, so you always got 80 .22 from a zombie.

now you get a randomized amount between 1-100. So it defaults to 50 (mathematically).

Describe the solution

Describe alternatives you've considered

different counts for different ammo types. Shotguns getting 1-50, pistols 1-200. But maybe it gets a tweak in the future.

Testing

old
grafik

new
grafik

Additional context

Checklist

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Jun 11, 2024
@chaosvolt
Copy link
Member

I should note that some items use a stack size of 20 or 80, so this may not actually be a good fit as-is.

@RobbieNeko
Copy link
Contributor

I'd have suggested yoinking the ammo amounts from nested_ammo.json personally. (or at least basing these amounts off of them, rather than just a 1-100 range that has a chance of being really disappointing if you get a very low roll)

@Lamandus
Copy link
Contributor Author

I should note that some items use a stack size of 20 or 80, so this may not actually be a good fit as-is.

yes, but we talked about it. These are those random ammo drops we get from zombies and in houses. They should be randomized. Because the stack sizes were random to begin with.

@Lamandus
Copy link
Contributor Author

I'd have suggested yoinking the ammo amounts from nested_ammo.json personally. (or at least basing these amounts off of them, rather than just a 1-100 range that has a chance of being really disappointing if you get a very low roll)

true, but sometimes you get some, you loose some. Now ammo spawns a lot more regularly (see house spawns), so the low rolls don't hurt that much.

Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suppose it works then but will leave this for others to look at.

@scarf005 scarf005 merged commit d0ffa51 into cataclysmbnteam:main Jun 12, 2024
10 checks passed
@Lamandus Lamandus deleted the ammo branch September 4, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants