Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove Ugly/Deformed from Feline/Lupine mutation path #5163

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

DoubleBullfrog
Copy link
Contributor

Required

Purpose of change

Feline and Lupine have both Ugly/Deformed and Pretty/Beautiful in their mutation categories, so often instead of advancing other mutations they will swap back and forth between Pretty and Ugly and waste your mutagen.

Describe the solution

Pick either being pretty or being ugly. I picked pretty.

Describe alternatives you've considered

Cat and Dog mutants could be ugly instead, but we've got a bunch of ugly mutants and not a lot of pretty ones.

Additional context

image

Feline and Lupine have both Ugly/Deformed and Pretty/Beautiful in their mutation categories, so often instead of advancing other mutations they will swap back and forth between Pretty and Ugly and waste your mutagen.
@github-actions github-actions bot added the data label Aug 7, 2024
@chaosvolt
Copy link
Member

Ah the eternal saga of tests being weirdly specific in what they're expecting, uuuugh

@chaosvolt
Copy link
Member

So I'm looking at this and...somehow, it considers plant mutation to be too strong because cats and wolves can no longer become ugly? That's uh...weird.

I dunno what kinda JSON solution would work to fix that. I feel like the flaw here might be that it's very unlikely that "test to" is even remotely needed for the test, because unlike "chance is too low" I see no obvious downside to it being too high.

@github-actions github-actions bot added the tests changes related to tests label Aug 8, 2024
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Load-tested on compiled test build.
  2. Chugged a fuckload of feline mutagen, then eventually tried some serum.
  3. Took a few tries but still got the threshold, seems that was more because there were a TON of feline traits already and it just kept wanting to give me a few more instead of breaching the threshold even after mutation category strength was well over 100.
  4. Repeated test with lupine mutagen, same general result. Lot of mutations to grant so threshold needing some extra help seems to just be RNG. I'd gotten "straining" messages indicating the mutagen was trying to breach a threshold too
  5. A second test with lupine mutagen, this time stopping when I saw a straining message to check category strength, showed that lupine was as expected the highest category, but only at a mere 64. Feline was second-closest at 45.
  6. Just in case did a plant mutagen test, it triggered the threshold immediately after only 10 doses of mutagen.

My rough guess is eventually, if I ever get around to overhauling mutation categories with more interlocked mutation chains and/or more specialized traits, the mammal categories in general will need more specialization.

@chaosvolt chaosvolt merged commit 8aa9613 into cataclysmbnteam:main Aug 8, 2024
11 checks passed
@Unrepentant-Atheist
Copy link

Unrepentant-Atheist commented Aug 9, 2024

But what aboot
image

or this:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests changes related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants