Update dependencies, mostly related to testing, plus sklearn 1.0. #1236
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1236 +/- ##
==========================================
+ Coverage 81.35% 81.55% +0.20%
==========================================
Files 52 52
Lines 6379 6379
==========================================
+ Hits 5189 5202 +13
+ Misses 1190 1177 -13
Continue to review full report at Codecov.
|
| @@ -98,7 +98,7 @@ | |||
| "finance", "eia 923", "eia 860", "ferc", "form 1", "epa ampd", | |||
| "epa cems", "coal", "natural gas", "eia 861", "ferc 714"], | |||
| python_requires=">=3.8,<3.10", | |||
| # setup_requires=["setuptools_scm"], | |||
| setup_requires=["setuptools_scm"], | |||
There was a problem hiding this comment.
Why was this uncommented? It looks like this usage has been deprecated.
There was a problem hiding this comment.
That's what I thought too, but in a lot of contexts it seems to be failing unless this is uncommented. I've got it in the pyproject.toml file as a required part of the build system, and it often doesn't seem to get picked up. Instead I end up seeing version catalystcoop.pudl v0.0.0 (e.g. at the beginning of test runs). But when it's uncommented, the versions always seem to show up correctly so... 🤷🏼♂️
There was a problem hiding this comment.
I just tested it again with the extra line they say to add -- the [tools.setuptools_scm] section header. And it still doesn't work, at least within Tox. So I think there's just lag in all the various packaging tools picking up on the pyproject.toml settings (which it seems like has been in place for years at this point), so I think we have the same thing specified in both places for maximal compatibility.
Also loosened the compatible pins on testing packages with v0.x