many_to_many relationships sometimes didn't work with lookup_options

Andrew Ruthven · Andrew Ruthven · commit 496d8f6013e0 · 2016-02-02T09:57:56.000+13:00
It looks like sometimes $new_result can return false. Use defined
instead so we always know if there is an object present.
diff --git a/lib/HTML/FormHandler/TraitFor/Model/DBIC.pm b/lib/HTML/FormHandler/TraitFor/Model/DBIC.pm
@@ -365,7 +365,7 @@ sub lookup_options {
         # check for many_to_many multiple select
         my $resultset = $self_source->resultset;
         my $new_result = $resultset->new_result( {} );
-        if ( $new_result && $new_result->can("add_to_$accessor") ) {
+        if ( defined $new_result && $new_result->can("add_to_$accessor") ) {
             $source = $new_result->$accessor->result_source;
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -365,7 +365,7 @@ sub lookup_options {`
`365`	`365`	`# check for many_to_many multiple select`
`366`	`366`	`my $resultset = $self_source->resultset;`
`367`	`367`	`my $new_result = $resultset->new_result( {} );`
`368`		`- if ( $new_result && $new_result->can("add_to_$accessor") ) {`
	`368`	`+ if ( defined $new_result && $new_result->can("add_to_$accessor") ) {`
`369`	`369`	`$source = $new_result->$accessor->result_source;`
`370`	`370`	`}`
`371`	`371`	`}`