Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Totara 13 stable version format #10

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

sumaiyamannan
Copy link
Contributor

Fixes the 'version number for Totara branches is 11 chars as oppose to the usual 10' issue.

@sumaiyamannan sumaiyamannan changed the base branch from MOODLE_35_STABLE to TOTARA_13_STABLE September 7, 2022 00:46
@danmarsden danmarsden merged commit 33feff5 into TOTARA_13_STABLE Sep 7, 2022
@danmarsden danmarsden deleted the TOTARA_13_STABLE_version_format branch September 7, 2022 00:55
@danmarsden
Copy link
Member

Thanks Sumaiya - can you also drop that change in for the MOODLE_35_STABLE branch as well?

@LiamKearn
Copy link

LiamKearn commented Sep 7, 2022

Ooh this is a clever little fix. We've never thought of using set_config we were using deployment scripts interfacing with cfg.php (which I'd guess uses that API under the hood anyways) if this ever happened :)

@keevan
Copy link

keevan commented Sep 7, 2022

Wouldn't this break upgrades for plugins that are not exactly on the current latest version before this change?

At least based on commits here: https://github.com/catalyst/moodle-local_maillog/commits/TOTARA_13_STABLE/version.php

e.g. 20170111100 and 20190317100

@danmarsden
Copy link
Member

Yeah good call - those versions are pretty ancient so I wouldn't expect to see them in the wild, but we could improve the check to prevent it from being a problem.. @sumaiyamannan can you please make that version check a little more flexible?

@sumaiyamannan
Copy link
Contributor Author

I have done it and created a PR #11
I had tested with version 20170111100 and 20190317100 and it worked smoothly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version number for Totara branches is 11 chars as oppose to the usual 10.
4 participants