Fix participants table #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The replacement for the unified filter (the participants filterset) does not support adding more than the courseid for a filter, so I've had to pretend the cmid is the courseid to pass it back to the reengagement table filterset when using the participants table. Additionally I had to remove the participant filters allowing you to filter by status etc at the top of the page. Again there isn't support for doing this with anything but the course id.
|
Tested on 3.10.6 |
|
Don't merge yet |
This was referenced Oct 28, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The replacement for the unified filter (the participants filterset)
does not support adding more than the courseid for a filter,
so I've had to pretend the cmid is the courseid to pass it back
to the reengagement table filterset when using the participants table.
Additionally I had to remove the participant filters allowing you to filter by
status etc at the top of the page. Again there isn't support for doing this
with anything but the course id.
For #94 #95