S3 pre-signed URL: error with unicode filename #455 #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brendanheywood One of our Catalyst EU clients is waiting on this fix, would you mind taking a look now its been rebased? |
marxjohnson
force-pushed
the
s3-pre-signed-url
branch
from
9a79b34
to
592e658
Compare
Change-Id: I6476fa2afac4aa5b28342629ac563a4ff2717c72
marxjohnson
force-pushed
the
s3-pre-signed-url
branch
from
592e658
to
5582738
Compare
|
@brendanheywood I have added unit tests to the branch, and an additional test file for the "Pre-Signed URL Testing" test page. I rebased the branch to put the tests before Phuc's commit, so it's easy to run the tests with and without the change, and see the error when you try and download the file with the unicode character. |
scara
reviewed
Jun 24, 2022
marxjohnson
force-pushed
the
s3-pre-signed-url
branch
from
b1d0e6a
to
863841c
Compare
Change-Id: Ia71b2789783da26e2c10875f2a4edf3d1b3951cd
marxjohnson
force-pushed
the
s3-pre-signed-url
branch
from
863841c
to
8e107e6
Compare
|
Reopen this PR as the following commit cause 403 error when retrieve files with pre-signed URL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased #456