Audio Event Detection GUI doesn't reflect jgmakin/ecogVIS updates

[emilyps14]

PR #76 was supposed to merge in changes from the changlab fork, but (at least) the Audio Event Detection GUI does not seem to have the design updates.

[luiztauffer]

@emilyps14 would you mind naming the design updates you’re missing, perhaps with a screenshot?
I tried to run jgmakin/ecogVIS with the EC208_B2.nwb file, but the old code lacks some changes to identify the mic recordings and I can’t open the CV Event Detector.

[emilyps14]

I'm having trouble getting the updated master branch to work for comparison but in the meantime here is what the jgmakin version looks like:

[emilyps14]

Some important features:

1. Separate thresholds for speaker and mic
2. Distinction between detection window and plotting window, and ability to omit times at the beginning and end of the recording (setting the detection window)
3. Showing the smooth traces and the threshold level in the window

Are these features in the most recent catalystneuro/ecogVIS master? I'm not seeing them, but maybe there's something wrong on my end

[luiztauffer]

hi @emilyps14 , thank you for the PR! I tried it here and it seems to be ok, but I don't have microphone signals (only noise), so I can't check if every detail is looking really how it should. Could you try to reproduce this with the current mater branch and see if this Issue can be closed?

[emilyps14]

Here is a screenshot of the same settings and data I used above, using the current master branch: