Add update_d8_version.py script #2

anniesullie · 2015-07-16T13:38:30Z

We should have a script that fetches the right binaries from the buildbots and patches them in, or just syncs the v8 code at the given revision and builds them itself.

We could either run this regularly as a cron job (see https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/recipes/catapult_cron.py) or make it so that we can run these as a tryjob on an as-needed basis.

We already have linux, windows, and mac slaves, so the buildbot part of this is not blocked, but I think ideally we would also have d8_runner use the new binary dependency system @Apeliotes is working on.

@nedn @natduca

zeptonaut · 2015-08-21T19:42:00Z

I'd love to keep D8 up-to-date to enable us to use ES6 features as they roll out. I'm going to look into how difficult this is.

nedn · 2015-08-21T19:49:30Z

Keeping as up-to-date as possible is not our strategy. Generated trace-viewer files has to support browsers up to stable, so we want d8 to be as up-to-date as stable chrome.

zeptonaut · 2015-08-21T19:52:39Z

Yep! Sorry - that was a really poor use of the phrase "up to date". "Up to stable" was more what I meant.

anniesullie · 2015-08-21T20:15:20Z

Some technical notes:

Here is some example code that finds out current chrome stable version
You can run your script on a nightly cron job here (currently linux-only)
Adding other platforms to run cron jobs can be done here -- you'd reuse mac_slave_pool and win_slave_pool

zeptonaut · 2015-08-25T14:20:43Z

After chatting with @anniesullie about this yesterday, it sounds like we could do this in a few logical steps:

Fetch the version number of Chrome stable from Omahaproxy
Fetch the version number of v8 that corresponds to Chrome stable from Omahaproxy
Clone the v8 git repository with a git tag matching the version number that we just fetched
Build v8 using depot_tools. This will require being on whatever platform you're building v8 for.
Check in to Catapult the binary that you just built.
Repeat for other two platforms.

After I have something like this working, I'll talk to @Apeliotes about how to go about working this into the dependency management framework that she's building, as well as how to use the slaves to do the builds rather than having to repeat this process on three operating systems.

This makes the process somewhat less manual. Eventually, we'd like to do this with a nightly cron job, but this script enables someone to do it locally, which is a step in the right direction. BUG=#2 Review URL: https://codereview.chromium.org/1313783008

…hset #2 id:20001 of https://codereview.chromium.org/1500843002/ ) Reason for revert: I am not sure how this was committed. The bots it ran on are all purple. If you look at the waterfall, it failed after this landed, and now the trybots are purple on every run. When I run locally on Mac, my devserver hangse at 24/42 tests run. Please fix these tests before resubmitting. Original issue's description: > Add test-picker and alerts-table instantiation tests. > > BUG=catapult:#1674 > > NOTRY=true > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/f6e65710a87758b4d5014c5de2418553ba0f76d9 TBR=qyearsley@chromium.org,chrisphan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=catapult:#1674 Review URL: https://codereview.chromium.org/1504363003

This ensures we won't use build-side python modules, and that any changes in src-side modules do take effect. This is a re-landing of https://codereview.chromium.org/1224593002 with a change to src/tools/telemetry/telemetry/TELEMETRY_DEPS . BUG=506498 Review URL: https://codereview.chromium.org/1218953003 Cr-Commit-Position: refs/heads/master@{#337387}

…nt/test/gpu. (patchset #2 id:20001 of https://codereview.chromium.org/1231863008/) Reason for revert: This CL appears to be causing flakes on android_webview_webgl_conformance_tests, webgl_conformance_tests and gpu_rasterization_tests. See, for example, https://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%209%29/builds/1079 https://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%205%29/builds/975 Original issue's description: > Refactored TestExpectations out of Telemetry and into content/test/gpu. > > (Re-land of https://codereview.chromium.org/1224233005/ after fix for > blink_canvas.perf benchmark) > > The GPU tests are the primary user of Telemetry's TestExpectations, > and it turns out they can be implemented entirely in the code using > Telemetry, rather than Telemetry itself. For this reason, move them > into content/test/gpu. > > Refactored the GPU tests to all derive from a common set of base > classes implementing support for test expectations. Verified that > skipping tests, expected failures, and flaky test handling all work. > More tests of test expectations are needed, and will be added in later > CLs; this one is too large already, but can't be broken up further. > > Fixed up two WebGL perf tests that were relying on test expectations > to skip the pages on specific GPUs, and added a hook to Telemetry's > browser_info to enable this. > > This CL loses one valuable test, > testHandlingOfCrashedTabWithExpectedFailure, from > page_run_end_to_end_unittest.py. It will be reintroduced in a later CL. > > A subsequent CL will redesign TestExpectations. This CL is intended to > be a refactoring with no behavioral changes. > > Ran telemetry_unittests, telemetry_gpu_unittests, > telemetry_perf_unittests, and all GPU tests locally to verify. > > BUG=495870 > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect > TBR=bajones@chromium.org,nednguyen@google.com,dtu@chromium.org,zmo@chromium.org > > Committed: https://crrev.com/296319ccdb96f3f31df22f3b4ced4e040a864210 > Cr-Commit-Position: refs/heads/master@{#338768} TBR=zhenw@chromium.org,bajones@chromium.org,nednguyen@google.com,dtu@chromium.org,aiolos@chromium.org,zmo@chromium.org,kbr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=495870 Review URL: https://codereview.chromium.org/1233303002 Cr-Commit-Position: refs/heads/master@{#338811}

(Re-land #2 with fixes for handling crashed renderers and other bug fixes) (Original CL: https://codereview.chromium.org/1224233005/ ) (Re-land #1: https://codereview.chromium.org/1231863008/ ) The GPU tests are the primary user of Telemetry's TestExpectations, and it turns out they can be implemented entirely in the code using Telemetry, rather than Telemetry itself. For this reason, move them into content/test/gpu. Refactored the GPU tests to all derive from a common set of base classes implementing support for test expectations. Verified that skipping tests, expected failures, and flaky test handling all work. More tests of test expectations are needed, and will be added in later CLs; this one is too large already, but can't be broken up further. Fixed up two WebGL perf tests that were relying on test expectations to skip the pages on specific GPUs, and added a hook to Telemetry's browser_info to enable this. This CL loses one valuable test, testHandlingOfCrashedTabWithExpectedFailure, from page_run_end_to_end_unittest.py. It will be reintroduced in a later CL. A subsequent CL will redesign TestExpectations. This CL is intended to be a refactoring with no behavioral changes. Ran telemetry_unittests, telemetry_gpu_unittests, telemetry_perf_unittests, and all GPU tests locally to verify. BUG=495870 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect TBR=bajones@chromium.org,nednguyen@google.com,dtu@chromium.org,zmo@chromium.org Review URL: https://codereview.chromium.org/1233133003 Cr-Commit-Position: refs/heads/master@{#339069}

…nstead of a dict. (patchset #2 id:280001 of https://codereview.chromium.org/1262623007/ ) Reason for revert: fails reliably on XP tests: https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20(1)/builds/39209/steps/telemetry_perf_unittests/logs/stdio Original issue's description: > Reland of Create classes_util API, change discover to return a list instead of a dict. (patchset #1 id:1 of https://codereview.chromium.org/1263063003/) > > Reason for revert: > The telemetry tests aren't broken. The perf_unittests are because they don't pick tests in a deterministic way. Reverting after a change to make them deterministic. > > Original issue's description: > > Revert of Create classes_util API, change discover to return a list instead of a dict. (patchset #5 id:120001 of https://codereview.chromium.org/1244223002/) > > > > Reason for revert: > > This appears to break the XP telemetry tests. Details on the bug. > > > > Original issue's description: > > > Create classes_util API, change discover to return a list instead of a dict. > > > > > > BUG=498968 > > > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect > > > > > > Committed: https://crrev.com/e6cbec4747aa7fe3c96b1cdb89de21ae77b30ab0 > > > Cr-Commit-Position: refs/heads/master@{#341129} > > > > TBR=dtu@chromium.org,bengr@chromium.org,aiolos@chromium.org > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=498968 > > > > Committed: https://crrev.com/c85e3e1af7e170d5f8ec2b012df6e9337d2352bb > > Cr-Commit-Position: refs/heads/master@{#341218} > > TBR=dtu@chromium.org,bengr@chromium.org,avi@chromium.org > BUG=498968 > > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect > > Committed: https://crrev.com/7e6fefcf3b839256c97e2e7bc0bfc3c53af75c8d > Cr-Commit-Position: refs/heads/master@{#341646} TBR=dtu@chromium.org,bengr@chromium.org,avi@chromium.org,aiolos@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=498968 Review URL: https://codereview.chromium.org/1267243002 Cr-Commit-Position: refs/heads/master@{#341692}

…gside TBMv2 (patchset #2 id:20001 of https://codereview.chromium.org/2073303002/ ) Reason for revert: Suspect making smoothness benchmarks failing, blocking catapult roll. See #2418 Original issue's description: > [Telemetry] Allow users to select TBMv1 metrics to run alongside TBMv2 > > This CL relaxes the restriction that users must choose either a list of TBMv1 > metrics, or a TBMv2 metric, to be run by a benchmark. It reconciles the legacy > functionality that selects all TBMv1 metrics by default in the following way: > > 1. If a TBMv2 metric is specified, any explicitly specified (using > SetLegacyTimelineBasedMetrics) v1 metrics will also be computed. > 2. If a TBMv2 metric is not specified, but TBMv1 metrics are specified, only > the selected TBMv1 metrics will be computed. > 3. If neither a TBMv2 metric nor any TBMv1 metrics are specified, all TBMv1 > metrics will be computed and no TBMv2 metric will be computed. > > BUG=chromium:621035 > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/054fe195c7bcf92dc42d2567492eb1e04281c0db TBR=eakuefner@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:621035 Review-Url: https://codereview.chromium.org/2073363002

…onfig (patchset #2 id:20001 of https://codereview.chromium.org/2083763002/ ) Reason for revert: failing tools/perf/measurements/smoothness_unittest.py Original issue's description: > Reland again - Move Chrome trace config API to ChromeTraceConfig > > Currently we have such APIs in TracingConfig, and then > redirected to ChromeTraceConfig. This CL removes that > redirection. > > BUG=catapult:#2413 > TBR=nednguyen@google.com > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/bcafc713474ebc0bfb2e3703ce46f44142cd86a0 TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=catapult:#2413 Review-Url: https://codereview.chromium.org/2080633005

…https://codereview.chromium.org/2066573004/ ) Reason for revert: Speculative revert to see if it is the cause for crbug/621489. Original issue's description: > Use DIP for scrolling tests. > > DIP stands for Device-Independent Pixel. Chrome on CrOS is configured > with IsUseZoomForDSFEnabled. On high-end devices with high DPI display > the return values from __GestureCommon_GetBoundingVisibleRect will be > the number of real pixels, which causes troubles as the scrolling > coordiates are expecting DIP. > > The fix here is to convert real pixel values back to DIP by dividing it > with window.devicePixelRatio. > > BUG=chromium:599656 > TEST=smoothness.top_25_smooth now passes on Pixel > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/91953db7ae2b087fdc2581c39d07e3862e31fa96 TBR=oshima@chromium.org,achuith@chromium.org,bccheng@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:599656 Review-Url: https://codereview.chromium.org/2086833003

…#2 id:60001 of https://codereview.chromium.org/2080183004/ ) Reason for revert: Cause TBMv2 benchmarks failure everywhere. BUG=623963 Original issue's description: > Change Numeric sourceInfos into sample diagnostics > > Currently, when metrics add samples to Numerics, they can optionally pass an > arbitrary POD javascript object to help users find the sample's source > in a trace. This concept maps directly to the new strongly-typed RelatedEventSet > diagnostic, or diagnostics more generally, which also provide a system to display > the data through tr.v.ui.createDiagnosticSpan(). > > This CL allows a single un-named Diagnostic object to be associated with each > sample. It may become necessary in the future to allow entire DiagnosticMaps to be > associated with each sample, but we haven't seen a need for that yet. > > A future CL will somehow need to associate sample diagnostics with IterationInfos > so that users can actually click through related events. > > BUG=catapult:#2180 > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/67bdb1c3d8755c1197598eb8f0a5032992979da5 TBR=eakuefner@chromium.org,benjhayden@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=catapult:#2180 Review-Url: https://codereview.chromium.org/2101233003

…duplicate keys indexed by class name (patchset #2 id:20001 of https://codereview.chromium.org/2075743002/ ) Reason for revert: Breaks all of the GPU tests on the Chromium waterfall: https://codereview.chromium.org/2136653002 https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/252404 Original issue's description: > [Telemetry] Make discover throw exceptions when it detects duplicate keys indexed by class name > > We don't throw exceptions when there is duplicate keys indexed by > module name because telemetry_perf_unittest currently depends on this > naming collision to reduce the number of benchmark it smokes test (bad!) > > This CL also renames linux_based_platform_backend_unittest.TestBackend classes to > linux_based_platform_backend_unittest.TestLinuxBackend to > avoid naming collision with posix_platform_backend_unittest.TestBackend (https://github.com/catapult-project/catapult/blob/a8a6fb7ea065c2df8ae129ad05ac80ba6ae7cc3a/telemetry/telemetry/internal/platform/posix_platform_backend_unittest.py#L13) > > > Change announcement: https://groups.google.com/a/chromium.org/forum/#!topic/telemetry-announce/i6FlJJDFWQA) > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/897866760cc7c37b766620f2589ad19026e775b1 TBR=kouhei@chromium.org,kbr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2137783002

…duplicate keys indexed by class name (patchset #1 id:1 of https://codereview.chromium.org/2137783002/ ) Reason for revert: GPU tests are updated to avoid naming conflict in https://codereview.chromium.org/2136773002/ BUG=chromium:627204 Original issue's description: > Revert of [Telemetry] Make discover throw exceptions when it detects duplicate keys indexed by class name (patchset #2 id:20001 of https://codereview.chromium.org/2075743002/ ) > > Reason for revert: > Breaks all of the GPU tests on the Chromium waterfall: https://codereview.chromium.org/2136653002 > https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/252404 > > Original issue's description: > > [Telemetry] Make discover throw exceptions when it detects duplicate keys indexed by class name > > > > We don't throw exceptions when there is duplicate keys indexed by > > module name because telemetry_perf_unittest currently depends on this > > naming collision to reduce the number of benchmark it smokes test (bad!) > > > > This CL also renames linux_based_platform_backend_unittest.TestBackend classes to > > linux_based_platform_backend_unittest.TestLinuxBackend to > > avoid naming collision with posix_platform_backend_unittest.TestBackend (https://github.com/catapult-project/catapult/blob/a8a6fb7ea065c2df8ae129ad05ac80ba6ae7cc3a/telemetry/telemetry/internal/platform/posix_platform_backend_unittest.py#L13) > > > > > > Change announcement: https://groups.google.com/a/chromium.org/forum/#!topic/telemetry-announce/i6FlJJDFWQA) > > > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/897866760cc7c37b766620f2589ad19026e775b1 > > TBR=kouhei@chromium.org,kbr@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/6cad5da3c39eca66c6dcd2db0b4cb1885fc00556 TBR=kouhei@chromium.org,kbr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2145693002

…ttps://codereview.chromium.org/2174543002/ ) Reason for revert: #2535 Original issue's description: > Optimize JSON dump in telemetry. > > This change makes the JSON dump go much faster (change from about > 8.5s to about 1.4s for a 330000-event trace) > > BUG=chromium:624164 > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/07aa51b63e8c04002a8696e63beacff9a8f2fbfc TBR=aschulman@chromium.org,charliea@chromium.org,sullivan@chromium.org,zhenw@chromium.org,nednguyen@google.com,alexandermont@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:624164 BUG=catapult:#2535 Review-Url: https://codereview.chromium.org/2177323002

…serdebug builds. (patchset #2 id:20001 of https://codereview.chromium.org/2275863002/ ) Reason for revert: Broke telemetry tests still using the old command line path Original issue's description: > [devil] Use /data/local/tmp for the command line on eng + userdebug builds. > > Matches https://codereview.chromium.org/2160243002 > > BUG=chromium:640228 > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/ae022b60c580ffbba455d620aab295372ac5ab0d TBR=rnephew@chromium.org,mikecase@chromium.org,jbudorick@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:640228,chromium:641497 Review-Url: https://codereview.chromium.org/2296943003

…l platforms (patchset #2 id:20001 of https://codereview.chromium.org/2287203003/ ) Reason for revert: The root cause should be fixed (see attaching bug) Original issue's description: > Disable WebviewInExtensionTest.testWebviewInExtension on all platforms > > It's flaky everywhere > > BUG=chromium:508325 > TBR=shadi@chromium.org, nednguyen@google.com > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/9dd53f60db07a5df78cc6a8078e5bd4f56275c65 TBR=shadi@chromium.org,achuith@chromium.org,afakhry@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:508325 Review-Url: https://codereview.chromium.org/2302583002

…mation. (patchset #2 id:20001 of https://codereview.chromium.org/2419023003/ ) Reason for revert: Suspect causing massive Android failure BUG=chromium:656224 Original issue's description: > [Android] Check list length before printing forwarder information. > > BUG=chromium:655653 > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/baf2eab473e1b1ddcefd5b601a6e66e2dde8cbc4 TBR=mikecase@chromium.org,zhenw@chromium.org,rnephew@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:655653 Review-Url: https://codereview.chromium.org/2425473002

…mation. (patchset #1 id:1 of https://codereview.chromium.org/2425473002/ ) Reason for revert: The revert did not fix the failure. It was something else. Original issue's description: > Revert of [Android] Check list length before printing forwarder information. (patchset #2 id:20001 of https://codereview.chromium.org/2419023003/ ) > > Reason for revert: > Suspect causing massive Android failure > > BUG=chromium:656224 > > Original issue's description: > > [Android] Check list length before printing forwarder information. > > > > BUG=chromium:655653 > > > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/baf2eab473e1b1ddcefd5b601a6e66e2dde8cbc4 > > TBR=mikecase@chromium.org,zhenw@chromium.org,rnephew@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:655653 > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/c1cc0281f791753f74dff4bc54ff77d416beb375 TBR=mikecase@chromium.org,zhenw@chromium.org,rnephew@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:656224 Review-Url: https://codereview.chromium.org/2419293002

…0001 of https://codereview.chromium.org/2444013002/ ) Reason for revert: Suspect this increases the flakiness of telemetry benchmarks smoke test. https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/323724 https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/318369 Original issue's description: > Update tsproxy copy to the latest version > > For the list of changes, see: > catchpoint/WebPageTest.tsproxy@6fae614...e0535f5 > > BUG=chromium:653519 > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/e14c7f729417e29f4be5b8580c000114a9ee6c5f TBR=pmeenan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:653519 Review-Url: https://codereview.chromium.org/2453463002

…atchset #2 id:20001 of https://codereview.chromium.org/2468113006/ ) Reason for revert: Breaking catapult roller? Will investigate more later. Original issue's description: > [telemetry] Always use a dynamic device port on android. > > BUG=chromium:661433 > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/37e8809ced4879e0a85a826afe404ec3f5a13b2a TBR=nednguyen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:661433 Review-Url: https://codereview.chromium.org/2477713002

…atchset catapult-project#2 id:20001 of https://codereview.chromium.org/2468113006/ ) Reason for revert: Breaking catapult roller? Will investigate more later. Original issue's description: > [telemetry] Always use a dynamic device port on android. > > BUG=chromium:661433 > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/37e8809ced4879e0a85a826afe404ec3f5a13b2a TBR=nednguyen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:661433 Review-Url: https://codereview.chromium.org/2477713002

…0001 of https://codereview.chromium.org/2553213002/ ) Reason for revert: Netlog test is failing, blocking catapult CQ: https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Mac%20Tryserver/builds/5929/steps/NetLog%20Viewer%20Dev%20Server%20Tests/logs/stdio Original issue's description: > re-enabled netlog viewer dev server tests > > BUG=catapult:#2702 > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/0b2f00a285c60fa162112bcc0681549e90f4e267 TBR=sullivan@chromium.org,wangyix@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=catapult:#2702 Review-Url: https://codereview.chromium.org/2566583003

…#2 id:20001 of https://codereview.chromium.org/2568033003/ ) Reason for revert: Testing to see if it caused the issue on Linux on the waterfall: https://bugs.chromium.org/p/chromium/issues/detail?id=674146 Original issue's description: > [Telemetry] Increase timeout after sending SIGTERM > > To shut down the browser on desktop, we first try to quit the browser normally, > then send SIGTERM, then wait a while, then send SIGKILL if we still don't see > that the browser is shut down. > > Apparently, with CHROME_HEADLESS=1, we should be getting a .dmp file on > SIGTERM, but we see no such file. > > kbr@ suggests that this may simply be because we're not waiting long enough. > The best result of this CL would be that we start getting useful stack traces > from these launch failures. > > BUG=catapult:#3074 > > Review-Url: https://codereview.chromium.org/2568033003 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/e6e0862c81652393de2dd878322e8c0c1e43d428 TBR=kbr@chromium.org,nednguyen@google.com,eakuefner@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=catapult:#3074 Review-Url: https://codereview.chromium.org/2570413002

@479

… id:240001 of https://codereview.chromium.org/2650683007/ ) Reason for revert: Fixing flakey test. Original issue's description: > Previously alert.py has some pre-hook logic to update associated groups. This involved several sync gets + query, with some potential puts and deletes. The newer implementation strips the pre-hook out in favour of heavily batching async calls when alerts are updated. > > So ran through StackDriver re-triaging a bug with 53 alerts (did the new one first so that any memcache boosts would benefit the old one not the new one), gathered these timings: > > Demo: https://dev-simonhatch-66cc9519-dot-chromeperf.appspot.com/ > > Old: > > @479 ms > https://monorail-prod.appspot.com/_ah/api/monorail/v1/projects/chromium/issues?alt=json&sendEmail=true > > <Modify Alerts> > > @10,430 ms > https://monorail-prod.appspot.com/_ah/api/monorail/v1/projects/chromium/issues/685469/comments?alt=json&sendEmail=true > > @11,354 ms > https://cr-buildbucket.appspot.com/api/discovery/v1/apis/buildbucket/v1/rest?userIp=2620%3A0%3A1000%3A1409%3A4c33%3Ac669%3A2634%3Af3bd > > > New: > > @770 ms > https://monorail-prod.appspot.com/_ah/api/monorail/v1/projects/chromium/issues?alt=json&sendEmail=true > > <Modify Alerts> > > @2,072 ms > https://monorail-prod.appspot.com/_ah/api/monorail/v1/projects/chromium/issues/685468/comments?alt=json&sendEmail=true > > @3,121 ms > https://cr-buildbucket.appspot.com/api/discovery/v1/apis/buildbucket/v1/rest?userIp=2620%3A0%3A1000%3A1409%3A4c33%3Ac669%3A2634%3Af3bd > > > This would put the old implementation at about 9951 ms vs 1302 ms in this particular run if I'm understanding these traces correctly. > > Could probably make some of these endpoints faster by returning futures from alert_group.ModifyAlertsAndAssociatedGroups() and weaving in with the surrounding functions (like in /file_bug we could theoretically async the issue_tracker stuff). > > Also might want to file an issue after to refactor some of this Alert/AlertGroup code. Seems a bit brittle that you have these associated groups that need to be updated whenever attributes on an alert are modified. > > BUG=catapult:#2771 > > Review-Url: https://codereview.chromium.org/2650683007 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/20c5e0b31c76cfbcf8ee0f629fe4c3069367f3c4 TBR=sullivan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=catapult:#2771 Review-Url: https://codereview.chromium.org/2670003006

…est runner (patchset #2 id:20001 of https://codereview.chromium.org/2671383003/ ) Reason for revert: Revert to try out the change in Chromium CQ Original issue's description: > [Telemetry] Migrate browser_test_runner to use typ as the test runner > > This is a reland of https://codereview.chromium.org/2671483002/. The > previous work was reverted to test out the change to gpu tests in chromium repo. > > Patch 1 is the original work, patch 2 & beyond includes fix for TearDownProcess > > BUG=chromium:636153 > TBR=kbr@chromium.org > > Review-Url: https://codereview.chromium.org/2671383003 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/12bf6ba0611a7c58086e665844f0fbf3321b578a TBR=dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:636153 Review-Url: https://codereview.chromium.org/2681453003

…ps://codereview.chromium.org/2841533003/ ) Reason for revert: Still causing certificate problem on Nexus bots :-( https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf%20%282%29/builds/5499 Screen shot from the log: https://console.developers.google.com/m/cloudstorage/b/chrome-telemetry-output/o/profiler-file-id_10-2017-04-25_00-51-2757619.png Original issue's description: > Roll WPR to the lastest commit > > List of changes: > > git log 6cffdf1fb6c9a6..66731e9ae8d3b3f7229 --date=short --no-merges --format='%ad %ae %s' > 2017-04-24 NghiaNguyenBH@gmail.com Update WPR documentation > 2017-04-17 rsleevi@chromium.org Whitespace > 2017-04-17 rsleevi@chromium.org Add unit test > 2017-04-17 rsleevi@chromium.org Explicitly set the version to X.509v3 > 2017-04-12 rsleevi@chromium.org Always include a subjectAltName and extendedKeyUsage extension in certs > > BUG=chromium:702194, chromium:711634 > TBR=ashleymarie@chromium.org,martiniss@chromium.org > > Review-Url: https://codereview.chromium.org/2841533003 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/892a0b6a45cc8b052638587744cc7a1b54efe2d4 TBR=rsleevi@chromium.org,mattm@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:702194, chromium:711634 Review-Url: https://codereview.chromium.org/2836303002

…:20001 of https://codereview.chromium.org/2890443002/ ) Reason for revert: Blocking roll. This can only be landed after https://chromium-review.googlesource.com/c/506017/ is landed. Original issue's description: > Remove webrtc_rendering_stats TBMv1 metrics > > These metrics are already converted to TBMv2 version: > https://github.com/catapult-project/catapult/blob/master/tracing/tracing/metrics/webrtc/webrtc_rendering_metric.html > > TBR=tdresser@chromium.org > > Review-Url: https://codereview.chromium.org/2890443002 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/f48086407653878212fe819a0ad0531132a4be98 TBR=ehmaldonado@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2886893003

… id:20001 of https://codereview.chromium.org/2914063002/ ) Reason for revert: Blocking catapult roll https://chromium-swarm.appspot.com/task?id=3679c73a83445210 Original issue's description: > devil: Add physical port num to device_status.py > > BUG=chromium:719093 > > Review-Url: https://codereview.chromium.org/2914063002 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/d8e5aec23bc3c86bb12b8b7a33faba22b335e56e TBR=jbudorick@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:719093 Review-Url: https://codereview.chromium.org/2920513003

…id:20001 of https://codereview.chromium.org/2946013004/ ) Reason for revert: Did not provide intended effect on the waterfall. Note to perf sheriffs: This is expected to cause several metric values to shift. Original issue's description: > [System Health] Extend dump time to 5 seconds > > Experiments have shown this significantly reduces noise > levels un gpu and cc memory infra metrics. > > BUG=chromium:734853 > > Review-Url: https://codereview.chromium.org/2946013004 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/b4eb70c319cb0f38d1a7764e7d9fb56dc96f8bcf TBR=ericrk@chromium.org,nednguyen@google.com,primiano@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:734853 Review-Url: https://codereview.chromium.org/2973253003

…) more strict (patchset #2 id:20001 of https://codereview.chromium.org/2994053002/ ) Reason for revert: breaking the roller: https://chromium-review.googlesource.com/c/612264 Original issue's description: > ApkHelper: Add GetViewActivityName(). Make GetActivityName() more strict > > GetActivityName() now looks for the launcher activity rather than just > returning the first activity. > > BUG=chromium:749239 > > Review-Url: https://codereview.chromium.org/2994053002 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/8a1ca7ff3ad0a5c4af93ba5b018c2c7d74cc276f TBR=agrieve@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:749239 Review-Url: https://codereview.chromium.org/3000783002

…s://codereview.chromium.org/3010173002/ ) Reason for revert: Broke catapult roll Original issue's description: > Smoke test for heap profiler. > > This test checks that heap profiler produced dumps. > > BUG=chromium:670828 > > Review-Url: https://chromiumcodereview.appspot.com/3010173002 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/c5a474f50f94f4df9cf979c1e7accc5515c79ca7 TBR=perezju@chromium.org,kraynov@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:670828 Review-Url: https://chromiumcodereview.appspot.com/3012033002

…20001 of https://codereview.chromium.org/3013043002/ ) Reason for revert: Causing issues on the chromedriver bot, https://bugs.chromium.org/p/chromium/issues/detail?id=767068 Original issue's description: > [devil] Update chromium build target deps. > > BUG=chromium:763167 > > Review-Url: https://chromiumcodereview.appspot.com/3013043002 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/d45d1a86b880ae2e549f3f45a2f62f4ed212d24f TBR=aluo@chromium.org,aluo@google.com,rnephew@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:763167 Review-Url: https://chromiumcodereview.appspot.com/3018583002

This CL will change Typ so that when the --retry-only-retry-on-failure-tests command line argument is passed, it will only retry tests that have the RetryOnFailure expectation. example expectations.txt: # tags: [foo] [foo] test_flaky [RetryOnFailure] [foo] test_fail [Pass] command: ./telemetry/bin/run_tests --retry-limit=2 --retry-only-retry-on-failure-tests -X expectations.txt -x foo output: [1/2] test_fail failed unexpectedly 0.234s [2/2] test_flaky failed unexpectedly 0.224s Retrying failed tests (attempt catapult-project#1 of 2)... [1/1] test_flaky failed unexpectedly 0.452s Retrying failed tests (attempt catapult-project#2 of 2)... [1/1] test_flaky passed 0.422s 1 test passed, 0 skipped, 1 failure. Bug: chromium:698902 Change-Id: I4c59db3284eefdfcfa2496cb940631e34d6e1d6b Reviewed-on: https://chromium-review.googlesource.com/c/1474603 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>

natduca mentioned this issue Aug 21, 2015

Need to have an automatic script that for updating d8 binary #1096

Closed

natduca added the Vinn label Aug 21, 2015

zeptonaut self-assigned this Aug 21, 2015

qyearsley-zz mentioned this issue Aug 27, 2015

Change bot select menu in test picker to single select. #1386

Closed

qyearsley-zz mentioned this issue Sep 3, 2015

Error in console upon re-assigning alert to a bug #1438

Closed

zeptonaut closed this as completed Sep 8, 2015

chiniforooshan mentioned this issue Jan 29, 2016

enabling the toplevel.flow category causes crashes #1935

Closed

ZiqiXiong mentioned this issue Jul 29, 2016

Bisect failures: bug updated multiple times with same results #2576

Open

zeptonaut mentioned this issue Sep 16, 2016

Catapult CQ blocked on failure to clock sync on Mac #2804

Closed

weableandbob mentioned this issue Mar 7, 2017

Uninstalling/reinstalling system apps #3341

Closed

dave-2 mentioned this issue Sep 26, 2017

Pinpoint: Make regression amounts clearer #3871

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add update_d8_version.py script #2

Add update_d8_version.py script #2

anniesullie commented Jul 16, 2015

zeptonaut commented Aug 21, 2015

nedn commented Aug 21, 2015

zeptonaut commented Aug 21, 2015

anniesullie commented Aug 21, 2015

zeptonaut commented Aug 25, 2015

Add update_d8_version.py script #2

Add update_d8_version.py script #2

Comments

anniesullie commented Jul 16, 2015

zeptonaut commented Aug 21, 2015

nedn commented Aug 21, 2015

zeptonaut commented Aug 21, 2015

anniesullie commented Aug 21, 2015

zeptonaut commented Aug 25, 2015