Skip to content
This repository has been archived by the owner on Dec 3, 2019. It is now read-only.

Dev server tests canary very flaky on Linux & Mac. Switch these to use dependency_manager #2138

Closed
nedn opened this issue Mar 15, 2016 · 8 comments
Closed

Dev server tests canary very flaky on Linux & Mac. Switch these to use dependency_manager #2138

nedn opened this issue Mar 15, 2016 · 8 comments
Assignees
@Apeliotes
Labels
Infrastructure P1
Milestone
M51

Comments

@nedn
Copy link
Contributor

nedn commented Mar 15, 2016

According to Annie, this is because urls it needs to download chrome return 400 for base_pos_lookup_url
chromium-infra-bot pushed a commit that referenced this issue Mar 15, 2016
@nedn
Disable dev server tests canary on Linux & Mac
7d8368d 
BUG=catapult:#2138
TBR=sullivan@chromium.org

Review URL: https://codereview.chromium.org/1800943002
@nedn nedn changed the title Dashboard dev server test canary is failing on Linux Dev server tests canary is failing on Linux & Mac Mar 15, 2016
@anniesullie
Copy link
Contributor

I added a debugging print, but now the flakiness has disappeared again. I'm guessing there may be a problem with omahaproxy not updating info about versions fast enough.

chromium-infra-bot pushed a commit that referenced this issue Mar 18, 2016
@nedn
Disable canary dev_server tests
3d31a5f 
BUG=catapult:#2138
TBR=sullivan@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1820483003
chromium-infra-bot pushed a commit that referenced this issue Mar 19, 2016
@nedn
Add more logging to run_dev_server_tests and set timeout for urllib2.…
725d4a2 
…urlopen

BUG=catapult:#2138
TBR=sullivan@chromium.org

Review URL: https://codereview.chromium.org/1813053006
@nedn nedn changed the title Dev server tests canary is failing on Linux & Mac Dev server tests canary very flaky on Linux & Mac. Switch these to use dependency_manager Mar 29, 2016
@nedn
Copy link
Contributor Author

nedn commented Mar 29, 2016

Assign this bug to Kari for migrating dev_server to use dependency_manager for fetching canary & reference.

@nedn nedn added this to the M51 milestone Mar 30, 2016
@nedn
Copy link
Contributor Author

nedn commented Mar 30, 2016

+Kari: can you work on this soon-ish? This is hurting our productivity/ products' stability really badly.

@nedn nedn added the P1 label Mar 30, 2016
@nedn
Copy link
Contributor Author

nedn commented Apr 5, 2016

Status update in https://docs.google.com/document/d/1u0W7I2YYlPf5dw8dJXt4qL-FV6LtAJx5UWYtRet2s8M/edit?ts=57043822 (Googler only)

@nedn nedn mentioned this issue Apr 7, 2016
Closed
@nedn
Copy link
Contributor Author

nedn commented Apr 7, 2016

The dev server tests are failing again today on stable channel, blocking Juan's CL: https://codereview.chromium.org/1857173002/

I don't disable the stable channels because that's the only coverage we have left for dev server tests. @Apeliotes maybe we can prioritize moving the dev server tests to use the stable browser binaries in https://github.com/catapult-project/catapult/blob/master/catapult_base/catapult_base/chrome_binaries.json for now? At least we don't have to worry about updating the stable browser binaries too often.

@nedn nedn mentioned this issue Apr 8, 2016
Closed
@nedn
Copy link
Contributor Author

nedn commented Apr 8, 2016

@Apeliotes Can you reenable canary tests that was disabled by 7d8368d?

chromium-infra-bot pushed a commit that referenced this issue Apr 12, 2016
@Apeliotes
Re-instate the window.XMLHttpRequest in mock teardown.
82f274b 
This should fix the dashboard dev server tests, and allow us to run
them on Canary.

BUG=catapult:#2138

Review URL: https://codereview.chromium.org/1885533003
chromium-infra-bot pushed a commit that referenced this issue Apr 12, 2016
@Apeliotes
Re-enable Dashboard Dev Server Tests Canary.
3fd3d5e 
BUG=catapult:#2138

Review URL: https://codereview.chromium.org/1877913002
@Apeliotes
Copy link
Contributor

I verified that dev server tests are running on canary after the last cl.

@Apeliotes
Copy link
Contributor

Please file a new bug or re-open if more flake is seen.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Apeliotes Apeliotes

Labels
Infrastructure P1
Projects
None yet
Milestone
M51
Development

No branches or pull requests
3 participants
@nedn @anniesullie @Apeliotes