Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1533 - Add support for Element Timing #1551

Merged
merged 6 commits into from
Sep 24, 2021
Merged

1533 - Add support for Element Timing #1551

merged 6 commits into from
Sep 24, 2021

Conversation

tkadlec
Copy link
Contributor

@tkadlec tkadlec commented Sep 24, 2021

Nice and shiny Element Timing API support thanks to Chrome's new trace events.

This PR closes #1533 by adding Element Timing to:

The JSON results:

"elementTiming": [
    {
        "identifier": "post-title",
        "time": 2070,
        "elementType": "text-paint",
        "url": ""
    },
    {
        "identifier": "post-hero",
        "time": 2200,
        "elementType": "image-paint",
        "url": "https:\/\/res.cloudinary.com\/webpagetest\/image\/upload\/f_auto,q_auto,c_fill,w_640,h_512\/august-roundup_plhjt4.png"
    }
],
"elementTiming.post-title": 2070,
"elementTiming.post-hero": 2200,

The custom waterfall page (using the same lines as the user timing API):
Screen Shot 2021-09-24 at 10 32 03 AM

The plot full results page:
Screen Shot 2021-09-24 at 10 33 54 AM

And the HTML table on results pages:

Screen Shot 2021-09-24 at 10 34 48 AM

Copy link
Contributor

@scottjehl scottjehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really nice. Useful addition!

@scottjehl scottjehl merged commit b4ea00d into master Sep 24, 2021
@scottjehl scottjehl deleted the 1533 branch September 24, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Element Timing support
2 participants