Merge to QA #1628
Merged
Merge to QA #1628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dvanced since Firefox supports these too. Closes #1558"
Move Disable Image Format checkboxes to Advanced
Design cleanups issues.
Overscroll only has wide as the filmstrip box
* fix(details): Change title order Fixes #1530 Made a custom page_title for each of the result pages and passed that through as well. Gave priority to the custom label and made sure to strip the url of everything but hostname.
fix(builds): We no longer use travis
Composer is a package manager for php (similar to npm for JavaScript or bundler for Ruby, etc.). We can use it to make sure we install the appropriate dependencies for our project. In this case, I'd like to install phpunit. Since this is a developer dependency, this will not break deployments as they stand, as these files are not required for the application to run, just for the tests to run
Also add a `composer test` script to make things easier
Need to include proper php version along with the gd extension (for imagecreatefrompng). Also make sure there's an absolute path being passed to imagecreatefrompng.
feat(unit tests): Add phpunit to our stuff
The threshold is when the filmstrip area is 60% of the viewport height. fixes #1578
A few div's are opened in the header.inc file if only a single test is being viewed, and then closed in footer.inc We need those elements either way, so for now, we're conditionally adding them in the PHP file.
fix(details) Fixes layout issues on graph full results when more than one test is viewed.
On short viewports, never use sticky filmstrips
…an be searched by email'
This isn't targeting people who shoot out 60 tests a month, it's a call to action for people who are running hundreds, so let's be lenient on the length of a "month". 28 days is fine
Chore: Add links from our about page
…thly-days fix(rate-limit): change length of default month
small cleanup to error messages in general while focusing on #1601.
Fixed some mobile emulation UA strings
This is a User model. It has some attributes on it that are important to understand about the current user as we build web pages, such as their email, if they are an admin, and whether or not they are a paid user. Have added this user as $current_user to the exported common.inc file so it will be referenced in any page that is used
feat(User): create User class
fix(common): missing paren
Handle the 0 available runs case.
This introduces the concept of a template helper. This can be used so we better separate our logic from our templates as we build out pages
* feat: track who hits the wall for monthly runs We want to know if these convert to sign-ups and how many people are actually doing it
I don't like this, but it works short term. Need to make sure we have a layout situation for this
feat(templates): using template for error page
* fix(head): add title with default layout * fixup! fix(head): add title with default layout
With the current code, somebody could potentially run 900 test runs (well, more since the cache is in-memory) before they hit the limit. Let's count every run.
Also add an event when signup is clicked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.