Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Expiration to alert #1976

Merged
merged 2 commits into from
Jun 7, 2022
Merged

Add Expiration to alert #1976

merged 2 commits into from
Jun 7, 2022

Conversation

deathbearbrown
Copy link
Contributor

This adds the option to include an alert_expiration timestamp in the settings.ini along side any alerts set there.

If there is no `alert_expiration' set then it's assumed the alert has no expiration. If it's past the date of expiration, the alert is not shown.

@deathbearbrown
Copy link
Contributor Author

my linter went to down on these files so please make sure you view it with whitespace turned off!
https://github.com/WPO-Foundation/webpagetest/pull/1976/files?diff=unified&w=1

Copy link
Contributor

@tkadlec tkadlec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@deathbearbrown deathbearbrown merged commit 424d888 into master Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants