-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
修復使用 bdk ca up 啟動 ICA 時,不會使用設定到期時間 #41
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kth-tw
requested changes
Dec 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-i
要改(現在ica不會問這些問題)- 這幾個參數要不要改名?
Lines 96 to 113 in e1e7a53
'rca-cn': { describe: '(RCA) Common name for RCA CSR if this is an RCA', type: 'string', }, 'rca-hosts': { describe: '(RCA) Hosts for RCA CSR if this is an RCA', type: 'string', }, 'rca-expiry': { describe: '(RCA) Certificate expiry for RCA CSR if this is an RCA', type: 'string', default: '131400h', }, 'rca-pathlength': { describe: '(RCA) Pathlength for RCA CSR if this is an RCA', type: 'number', default: 0, },
kth-tw
requested changes
Jan 6, 2022
SecondDim
approved these changes
Jan 11, 2022
kth-tw
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
說明 (Description)
修復使用 bdk ca up 啟動 ICA 時,不會使用設定到期時間
相關問題 (Linked Issues)
貢獻種類 (Type of change)
測試環境 (Test Configuration):
檢查清單 (Checklist):
我已完成以上清單,並且同意遵守 Code of Conduct
I have completed the checklist and agree to abide by the code of conduct.