fix: repo is now template conform #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
| # - ~/.config/alacritty/catppuccin/catppuccin-frappe.yml | ||
| # - ~/.config/alacritty/catppuccin/catppuccin-latte.yml | ||
| - ~/.config/alacritty/catppuccin/themes/catppuccin-mocha.yml | ||
| # - ~/.config/alacritty/catppuccin/themes/atppuccin-macchiato.yml |
There was a problem hiding this comment.
âttpùccín 🥖🥐
I'll push a fix the next week
README.md
Outdated
| @@ -12,9 +12,27 @@ | |||
| </p> | |||
|
|
|||
| <p align="center"> | |||
| <img src="assets/screenshot.webp"/> | |||
| <img src="https://raw.githubusercontent.com/catppuccin/alacritty/main/assets/preview.webp"/> | |||
There was a problem hiding this comment.
I believe that hard-linking the preview images is a mistake. The preview on the template repo is only hard-linked because the image itself is from a completely different repo altogether.
Port-readmes usually just softlink the previews. c:
<p align="center">
<img src="assets/preview.webp"/>
</p>
## Previews
<details>
<summary>🌻 Latte</summary>
<img src="assets/latte.webp"/>
</details>
<details>
<summary>🪴 Frappé</summary>
<img src="assets/frappe.webp"/>
</details>
<details>
<summary>🌺 Macchiato</summary>
<img src="assets/macchiato.webp"/>
</details>
<details>
<summary>🌿 Mocha</summary>
<img src="assets/mocha.webp"/>
</details>There was a problem hiding this comment.
I've heard both over time, we should declare that somewhere, but changes are on their way non-the less :)
|
@andreasgrafen added your changes (with a week delay :o) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some light work for hacktoberfest ;)