build: integrate whiskers #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nullishamy
changed the title
uncenter
suggested changes
May 13, 2024
Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>
uncenter
reviewed
May 14, 2024
uncenter
suggested changes
May 14, 2024
Comment on lines
+16
to
+17
| "name": "Catppuccin Chrome Theme - {{ flavor.identifier | capitalize }} {{ accent | capitalize }}", | ||
| "description": "Soothing pastel theme for Google Chrome - Catppuccin {{ flavor.identifier | capitalize }}", |
There was a problem hiding this comment.
Suggested change
| "name": "Catppuccin Chrome Theme - {{ flavor.identifier | capitalize }} {{ accent | capitalize }}", | |
| "description": "Soothing pastel theme for Google Chrome - Catppuccin {{ flavor.identifier | capitalize }}", | |
| "name": "Catppuccin Chrome Theme - {{ flavor.name }} {{ accent | capitalize }}", | |
| "description": "Soothing pastel theme for Google Chrome - Catppuccin {{ flavor.name }}", |
Same with the Google Store one if we are keeping that.
There was a problem hiding this comment.
I had kept it this way to avoid the accent on Frappe, don't want to run the risk of breaking things.
There was a problem hiding this comment.
I think Chrome fully supports Unicode? Would be very surprised if they didn't lol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also restructures the themes to be more organised / sensibly named.