Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable byte-compile for faster startup #146

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Conversation

rafagil
Copy link
Contributor

@rafagil rafagil commented Apr 23, 2024

This PR should fix the issue 127
I've been using this byte-compiled for a long time now without any issues.

Results on my machine (See the load times):
Without byte-compile:
Screenshot 2024-04-23 at 16 22 16

With byte-compile:
Screenshot 2024-04-23 at 16 23 10

@jtbx
Copy link
Member

jtbx commented May 6, 2024

Why is no-byte-compile even set in the first place? Also I think you should be able to remove the whole variable rather than set it to nil.

@rafaelinsightterra
Copy link

@jtbx I have no idea, my guess it was for some debugging. I could remove the variable, but maybe keeping it prevents other people to accidentally add it? But whatever the maintainers prefer.

@NamesCode NamesCode self-requested a review June 2, 2024 03:31
Copy link
Member

@NamesCode NamesCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All look good to me ^^
Tested and no issues as far as I could see.

@NamesCode NamesCode merged commit 55cf3fa into catppuccin:main Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants