feat: erc theming #147
Merged
feat: erc theming #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtbx
requested changes
May 8, 2024
jtbx
approved these changes
May 9, 2024
|
Thanks @jtbx! The interface is new for me, I found I could do it on the last 3, lol. I'll try to fix it, but idn, I wish a "squash commits" option here. |
Co-Authored-By: Jeremy Baxter <jtbx@duck.com>
|
@jtbx looks like "I did it" :) |
|
Awesome thanks a lot. :) |
|
Sorry for being so late to this. It looks amazing, thanks ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some github boo boo happened, I deleted my local repo and the pull request got messed, so "reopening" I guess.
Original from:
#144
Last message to @NamesCode
Hey @NamesCode! I made a mistake!
I have an extention to provide colorization, I turned it off to take the screenshots but I uploaded the wrong files, lol (https://github.com/leathekd/erc-hl-nicks by the way).
ERC by default does not make distintions between nicks in terms of colors.
Allow me some right screenshots here:
Private chat:
Channel chat:
Server buffer:
Regarding theming the `erc-hl-nicks' package, I would wait until the new version of ERC comes to Emacs 29. It should change some behaviours, how knows if we get some new faces :)