Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(home-manager/cava): add support for themes with transparent background #191

Merged
merged 1 commit into from
May 28, 2024

Conversation

AdrienCos
Copy link
Contributor

Description

This PR adds a new option to the programs.cava.catppuccin module, called transparent. Similarly to the programs.k9s.catppuccin.transparent, it is a boolean used to select the flavor variant with a transparent background.

This new feature has been added in this PR: catppuccin/cava#11, the source for cava therefore needs to be updated.

This should not be a breaking change, as the option defaults to false, which will in turn use the same theme file as currently.

Note: this PR is still in draft until the aforementioned PR in the source repo is merged, at which time the second commit will be updated to track catppuccin/cava.

@uncenter
Copy link
Member

feat(home-manager/cava): add support for themes with transparent background would probably be the proper conventional commit message for the PR title :)

@AdrienCos AdrienCos changed the title feat: cava: add support for themes with transparent background feat(home-manager/cava): add support for themes with transparent background May 22, 2024
@AdrienCos
Copy link
Contributor Author

feat(home-manager/cava): add support for themes with transparent background would probably be the proper conventional commit message for the PR title :)

Oops, sorry about that, fixed it :)

@AdrienCos AdrienCos force-pushed the feat/add-cava-transparent-themes branch from 3e5a34f to cae2f75 Compare May 25, 2024 12:07
@AdrienCos AdrienCos marked this pull request as ready for review May 25, 2024 12:09
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@getchoo getchoo merged commit ba40680 into catppuccin:main May 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants