Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git diffs blend in the background in lualine #15

Closed
ashincoder opened this issue Aug 28, 2021 · 10 comments
Closed

git diffs blend in the background in lualine #15

ashincoder opened this issue Aug 28, 2021 · 10 comments

Comments

@ashincoder
Copy link

Hi @pocco81 .
I absolutely love this theme.
But one thing that concerned me was after editing a file there would be some diffs right. So the count of the diffs are blended to background in lualine.
Here is the screenshot:
2021-08-28-171202_510x85_scrot

@ashincoder
Copy link
Author

and also could u make the todo comments more bold. It would be a nice touch.. 😄

pocco81 added a commit that referenced this issue Aug 28, 2021
@pocco81
Copy link
Member

pocco81 commented Aug 28, 2021

If you want pretty TODO comments then I'd recommend ya todo-comments.nvim . They looks very cool:

image

@ashincoder
Copy link
Author

That's enough. I just want the todo comments bolder. That's it thank you.

@pocco81
Copy link
Member

pocco81 commented Aug 29, 2021

Wait so you don't want the diffs in lualine to be more visible? I think I'm still gonna do this...

@ashincoder
Copy link
Author

I want it visible. But it's too blended in the lualine.

@ashincoder
Copy link
Author

I can't see it properly

@ashincoder ashincoder reopened this Aug 29, 2021
@pocco81
Copy link
Member

pocco81 commented Aug 29, 2021

Looking good now:

image

@ashincoder
Copy link
Author

yes
it does 👍

@pocco81
Copy link
Member

pocco81 commented Aug 29, 2021

This issue made realize that I was handling diffs and git stuff differently although they both reflect the same thing: changes in a file. So I ended up refactoring that part and this is how it looks with various integrations enabled (the things in the red boxes):

image

I still need to update the doc before this gets to main tho.

@pocco81
Copy link
Member

pocco81 commented Aug 29, 2021

Ok it's all merged. Enjoy 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants