Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lspsaga): support v0.2.7 #411

Merged
merged 2 commits into from
Feb 19, 2023

Conversation

Jint-lzxy
Copy link
Contributor

This PR added support for lspsaga@v0.2.7. Changes include:

  • Implemented new highlight groups;
  • The LspKind* highlight groups are used to set the colors for lspkind icons (finally!)
    • Note: Those highlights do not belong to any integration. I added them to support "dynamically changing flavors when editing". Not sure if this is the best way to do so.

It'll be marked as ready for review after changes are merged upstream 👍

@nullchilly
Copy link
Contributor

In favour of directly using SagaWinbarClass = { link = "Class } instead of custom_kind because lspsaga makes no effect to preserve highlight groups on ColorScheme event

@Jint-lzxy
Copy link
Contributor Author

In favour of directly using SagaWinbarClass = { link = "Class } instead of custom_kind because lspsaga makes no effect to preserve highlight groups on ColorScheme event

@nullchilly Sorry, I can't quite understand that. Now lspsaga uses highlight groups to which the lspkind icons are linked to set all its colors. If we only set highlights for winbar, the icons for other features (such as outline) will have no color then. IMO lspsaga can handle this correctly now, see: lspkind.lua#L110.

Did I miss something here?

@nullchilly nullchilly marked this pull request as ready for review February 19, 2023 14:44
@nullchilly nullchilly merged commit d15bed2 into catppuccin:main Feb 19, 2023
@Jint-lzxy Jint-lzxy deleted the feat/lspsaga-v0.2.7 branch February 19, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants