Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nixos-wiki): unthemed search bar #1050

Merged
merged 8 commits into from Jul 7, 2024
Merged

fix(nixos-wiki): unthemed search bar #1050

merged 8 commits into from Jul 7, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jul 6, 2024

i was doing some testing with the nixos.wiki userstyle and i found out that the search bar wasn't themed so i decided to fix it

image
image

@github-actions github-actions bot added the nixos.wiki NixOS Wiki label Jul 6, 2024
@ghost ghost changed the title fix(nixos-wiki) unthemed search bar fix(nixos-wiki): unthemed search bar Jul 6, 2024
styles/nixos.wiki/catppuccin.user.css Outdated Show resolved Hide resolved
styles/nixos.wiki/catppuccin.user.css Outdated Show resolved Hide resolved
styles/nixos.wiki/catppuccin.user.css Outdated Show resolved Hide resolved
styles/nixos.wiki/catppuccin.user.css Outdated Show resolved Hide resolved
styles/nixos.wiki/catppuccin.user.css Outdated Show resolved Hide resolved
styles/nixos.wiki/catppuccin.user.css Show resolved Hide resolved
@uncenter

This comment has been minimized.

@isabelroses
Copy link
Member

Seeing as nixos.wiki is no longer the suggested wiki site (see #781) I'm not inclined to accept fixes for this userstyle. Thoughts @isabelroses?

I don't see too much harm in accepting fixes but ideally we should push for a new theme

@ghost ghost requested a review from isabelroses July 6, 2024 20:34
Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Rember to update the version number

  2. These update seems to break some stuff here
    image
    image

@ghost
Copy link
Author

ghost commented Jul 6, 2024

dw i'll fix it

@ghost
Copy link
Author

ghost commented Jul 6, 2024

@isabelroses fixed
image

@ghost ghost requested a review from isabelroses July 6, 2024 21:31
@uncenter
Copy link
Member

uncenter commented Jul 6, 2024

See lint error.

@ghost
Copy link
Author

ghost commented Jul 7, 2024

@uncenter fixed

@ghost
Copy link
Author

ghost commented Jul 7, 2024

i also added some border colors to make it look pretty good
image

@isabelroses isabelroses merged commit 258f345 into catppuccin:main Jul 7, 2024
5 checks passed
@ghost ghost deleted the feat/nixos-wiki-fix branch July 7, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nixos.wiki NixOS Wiki
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants