Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribute configuration defaults to VSCode Peacock #284

Open
repraze opened this issue Jan 7, 2024 · 1 comment
Open

Contribute configuration defaults to VSCode Peacock #284

repraze opened this issue Jan 7, 2024 · 1 comment
Labels

Comments

@repraze
Copy link

repraze commented Jan 7, 2024

I'm looking to add support for peacock and previously created a repo for it to allow for the user to change favorite colors.

Currently this vscode theme only allow for extensions to swap out color contributions from vscode extensions. However peacock does not contribute any colors to the vscode theme and favorites colors are a configuration contribution.

The type generation only allows for contributes.colors to be extracted and changed. I'm not sure what the best solution is here to allow for contributes.configuration.properties.favoriteColors to be changed/edited when changing the theme.

I'm not sure if this means the property is not themable in this case. If this cannot be supported, please reopen the original issue.

@nekowinston
Copy link
Contributor

nekowinston commented Jan 7, 2024

I'm not really familiar with VSCode Peacock, looking at the theme files in your repo, it looks like those are settings.json values intended for use with Peacock installed and activated instead of Catppuccin? In that case, we could probably use https://code.visualstudio.com/api/references/contribution-points#contributes.configurationDefaults 🤔

@sgoudham sgoudham changed the title Allow for configuration overrides / replacement Contribute configuration defaults to VSCode Peacock Nov 9, 2024
@sgoudham sgoudham added enhancement New feature or request needs investigation labels Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants